Make sure integration-cli tests clean up#9249
Merged
LK4D4 merged 2 commits intomoby:masterfrom Nov 19, 2014
Merged
Conversation
Contributor
|
awesome!! |
Contributor
|
LGTM |
Common patterns: - Multiple images were built with same name but only one cleanup. - Containers were deleted after images. - Images not removed after retagging. Signed-off-by: Tõnis Tiigi <tonistiigi@gmail.com> (github: tonistiigi)
Pass every image name as separate argument. Signed-off-by: Tõnis Tiigi <tonistiigi@gmail.com> (github: tonistiigi)
193acbb to
bbb245d
Compare
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Nov 19, 2014
Make sure integration-cli tests clean up
Contributor
|
@tonistiigi Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common patterns:
Signed-off-by: Tõnis Tiigi tonistiigi@gmail.com (github: tonistiigi)
This will become more important when there is progress with #9217 . Even at the moment when
integration-cliis ran inside temporary container this can easily result false positives when one test leaks information to another. Currently there are many tests that do not pass if ran for a second time in same environment.edit: pushed again diff