-
Notifications
You must be signed in to change notification settings - Fork 18.9k
WIP - Enable test-integration-cli for client-side only platforms #9217
Copy link
Copy link
Closed
Labels
kind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.
Description
As written today, test-integration-cli expect:
- To be running inside a container (cf.
project/make.sh) - To have a local daemon to talk to (cf.
project/make/test-integration-cli)
Some platforms only support the client-side of Docker, yet we would obviously want integrations tests to cover them. Before diving into implementation, I'd like to be sure we agree on the proper way to achieve this. I'm thinking:
- Use the existing
DOCKER_CLIENTONLYvariable in some way for test execution, for example as a mean to excludedocker_cli_daemon_test.gofrom the run - Take
DOCKER_HOSTenvironment variable into consideration for every interactions with the daemon: this does mean that you can end up polluting a running daemon with test data if you're not careful - Go through individual tests to check which rely on the assumptions of a local daemon running, if any
Ping @tianon as maintainer: do you have objection and/or suggestions on the proper way to do this?
Ping @ahmetalpbalkan who surely will be interested
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/enhancementEnhancements are not bugs or new features but can improve usability or performance.Enhancements are not bugs or new features but can improve usability or performance.