Skip to content

WIP - Enable test-integration-cli for client-side only platforms #9217

@icecrime

Description

@icecrime

As written today, test-integration-cli expect:

Some platforms only support the client-side of Docker, yet we would obviously want integrations tests to cover them. Before diving into implementation, I'd like to be sure we agree on the proper way to achieve this. I'm thinking:

  • Use the existing DOCKER_CLIENTONLY variable in some way for test execution, for example as a mean to exclude docker_cli_daemon_test.go from the run
  • Take DOCKER_HOST environment variable into consideration for every interactions with the daemon: this does mean that you can end up polluting a running daemon with test data if you're not careful
  • Go through individual tests to check which rely on the assumptions of a local daemon running, if any

Ping @tianon as maintainer: do you have objection and/or suggestions on the proper way to do this?
Ping @ahmetalpbalkan who surely will be interested

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/enhancementEnhancements are not bugs or new features but can improve usability or performance.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions