As written today, test-integration-cli expect:
Some platforms only support the client-side of Docker, yet we would obviously want integrations tests to cover them. Before diving into implementation, I'd like to be sure we agree on the proper way to achieve this. I'm thinking:
- Use the existing
DOCKER_CLIENTONLY variable in some way for test execution, for example as a mean to exclude docker_cli_daemon_test.go from the run
- Take
DOCKER_HOST environment variable into consideration for every interactions with the daemon: this does mean that you can end up polluting a running daemon with test data if you're not careful
- Go through individual tests to check which rely on the assumptions of a local daemon running, if any
Ping @tianon as maintainer: do you have objection and/or suggestions on the proper way to do this?
Ping @ahmetalpbalkan who surely will be interested
As written today,
test-integration-cliexpect:project/make.sh)project/make/test-integration-cli)Some platforms only support the client-side of Docker, yet we would obviously want integrations tests to cover them. Before diving into implementation, I'd like to be sure we agree on the proper way to achieve this. I'm thinking:
DOCKER_CLIENTONLYvariable in some way for test execution, for example as a mean to excludedocker_cli_daemon_test.gofrom the runDOCKER_HOSTenvironment variable into consideration for every interactions with the daemon: this does mean that you can end up polluting a running daemon with test data if you're not carefulPing @tianon as maintainer: do you have objection and/or suggestions on the proper way to do this?
Ping @ahmetalpbalkan who surely will be interested