I'm hitting a bug when combining Tar() + http chunked transfer, closing until I can find it.

So the bug was not in this branch after all (and was separately fixed in #885).

I'm ready for review /cc @creack @vieux

ping @creack @vieux

I see there is an update of APIVERSION, could you add some doc ?

ping @creack

Couple of minor things:

• If we remove the unitTestImageName constant, it might be interesting to remove it everywhere.
• The tests require internet connectivity.
• This most likely rejects and close Allow separate Dockerfile from context #901.
• As mentioned by @vieux, the api version changed, so we need to create a docker_remote_api_v1.3.rst file in the docs.

Otherwise, LGTM

Actually I need to bring back the multipart upload code to keep reverse compatibility with 1.2 clients and daemons... :(

Closing until that's done.

I added documentation for 1.3 API.

I also added a warning for clients connecting to /build for version 1.2 or older. Ideally we would preserve reverse-compatibility with the old build method, but it would be a lot of work for not much benefit, since the API should still be considered unstable anyway.

Therefore I am ready for review @vieux @creack

The whole docs/sources/api/docker_remote_api.rst needs to be updated (current version 1.3, 1.3 section with what's new)

Otherwise, LGTM

FIxed references to 1.3.

I can't find the "what's new" section in the other versions of the API docs. Should I just add one?

There is an issue with the merge. commands.go l196, cli.host and cli.port does not exist anymore, it has been replaced by cli.addr.
The TestBuild fails. There is an issue with ADD, for some reason ADD foo /usr/lib/bla/bar puts foo in /usr/lib/bla.

Yeah I'm aware of that ADD problem, fix underway. (But I think it's
orthogonal to #900, I believe it's already present in master).

On Thu, Jun 20, 2013 at 4:24 PM, Guillaume J. Charmes <
notifications@github.com> wrote:

There is an issue with the merge. commands.go l196, cli.host and cli.port
does not exist anymore, it has been replaced by cli.addr.
The TestBuild fails. There is an issue with ADD, for some reason ADD foo
/usr/lib/bla/bar puts foo in /usr/lib/bla.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/900#issuecomment-19790106
.

Ok, we should be good. I have fixed ADD behavior and added tons of regression tests. It's also much easier to add new tests for builds with non-empty contexts.

Ping @victor @creack

Small merge issue around line 200 in commands.go

diff --git a/commands.go b/commands.go
index 5dffdcc..8e057c4 100644
--- a/commands.go
+++ b/commands.go
@@ -197,7 +197,14 @@ func (cli *DockerCli) CmdBuild(args ...string) error {
                return err
        }
        req.Header.Set("Content-Type", "application/tar")
-       resp, err := http.DefaultClient.Do(req)
+       dial, err := net.Dial(cli.proto, cli.addr)
+       if err != nil {
+               return err
+       }
+       clientconn := httputil.NewClientConn(dial, nil)
+       resp, err := clientconn.Do(req)
+       defer clientconn.Close()
        if err != nil {
                return err
        }

And you still need to update http://docs.docker.io/en/latest/api/docker_remote_api/

Also, nothing new (same issue in master) but when your Dockerfile doesn't contain any CMD,
the builded image can be run without any command and will execute the last RUN command in the from the Dockerfile.
I think it should be fixed by this PR.

About the api doc update - what needs to be updated exactly?
—
@solomonstre
@getdocker

On Fri, Jun 21, 2013 at 5:54 AM, Victor Vieux notifications@github.com
wrote:

Small merge issue around line 200 in commands.go
diff --git a/commands.go b/commands.go
index 5dffdcc..8e057c4 100644
--- a/commands.go
+++ b/commands.go
@@ -197,7 +197,14 @@ func (cli *DockerCli) CmdBuild(args ...string) error {
return err
}
req.Header.Set("Content-Type", "application/tar")
- resp, err := http.DefaultClient.Do(req)
+ dial, err := net.Dial(cli.proto, cli.addr)
+ if err != nil {
+ return err
+ }
+ clientconn := httputil.NewClientConn(dial, nil)
+ resp, err := clientconn.Do(req)
+ defer clientconn.Close()
if err != nil {
return err
}

And you still need to update http://docs.docker.io/en/latest/api/docker_remote_api/

Reply to this email directly or view it on GitHub:
#900 (comment)

in docker_remote_api.rst

you should change The current verson of the API is 1.2 to 1.3 and add the 1.4 section:

:doc:`docker_remote_api_v1.3`
*****************************

What's new
----------

.....