Skip to content

Remove bsdtar by checking magic#885

Merged
creack merged 8 commits into
masterfrom
remove_bsdtar
Jun 19, 2013
Merged

Remove bsdtar by checking magic#885
creack merged 8 commits into
masterfrom
remove_bsdtar

Conversation

@creack

@creack creack commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

Remove bsd dependency

FIxes #339

@vieux

vieux commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

LGTM, we could probably add some tests, like TestTarUntar with some compressions

@vieux vieux mentioned this pull request Jun 14, 2013
Closed
@shykes

shykes commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

Yes please, lots and lots of tests, this is a critical codepath.
—
@solomonstre
@getdocker

On Fri, Jun 14, 2013 at 3:57 AM, Victor Vieux notifications@github.com
wrote:

LGTM, we could probably add some tests, like TestTarUntar with some compressions

Reply to this email directly or view it on GitHub:
#885 (comment)

@vieux

vieux commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

We should also update the doc, to remove all bsdtar references

@jpetazzo

jpetazzo commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

And package control information, to remove the dependency! :-)

@unclejack

unclejack commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

The package xz-utils must be installed if bsdtar is to be given up on.
bsdtar has lzma integrated into it, so it doesn't rely on an external process. It didn't seem to require xz-utils either.

@jpetazzo

jpetazzo commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

Oh, good catch. Right.

@unclejack

unclejack commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

Here's an example:

docker run -i -t -m 16777216 ubuntu:12.04 bash

root@1981b05daa68:/root# xz
bash: xz: command not found
root@1981b05daa68:/root# tar -Jcpf bla.tar.xz bla
tar (child): xz: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
root@1981b05daa68:/root#

docker run -i -t -m 16777216 ubuntu:12.10 bash

root@0909a394473c:/root# xz
bash: xz: command not found
root@0909a394473c:/root# tar -Jcpf bla.tar.xz bla
tar (child): xz: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now

By the way, switching away from bsdtar might really trigger an issue like the one described in #791.
bsdtar seems to be a tad smarter, but I've run into that problem with gnu tar.

@jpetazzo

jpetazzo commented Jun 14, 2013

Copy link
Copy Markdown
Contributor

Oh, I think #791 will be fine; but I'll reply on it directly to avoid
mixing issues :-)

@creack
Merge branch 'master' into remove_bsdtar
abf85b2 
Conflicts:
	docs/sources/contributing/devenvironment.rst
@creack creack mentioned this pull request Jun 17, 2013
Closed
@shykes shykes mentioned this pull request Jun 18, 2013
Merged
@shykes

shykes commented Jun 18, 2013

Copy link
Copy Markdown
Contributor

I fixed a few references to bsdtar in Vagrantfiles, install script etc.

LGTM

@vieux

vieux commented Jun 18, 2013

Copy link
Copy Markdown
Contributor

I'm not able to pull toorop/golang

Do you have the same issue ?

@creack

creack commented Jun 18, 2013

Copy link
Copy Markdown
Contributor Author

works fine for me

@creack

creack commented Jun 18, 2013

Copy link
Copy Markdown
Contributor Author

@shykes, did you try?

@vieux

vieux commented Jun 18, 2013

Copy link
Copy Markdown
Contributor

@creack seems ok now, so probably unrelated to this PR, here is the debug output of the faillure:

Pulling repository toorop/golang from https://index.docker.io/v1
Pulling image 27cf784147099545 () from toorop/golang
Pulling image 6a667a081302b8c50169b030f06bcce53ba9c48c8d4e82293f4dab4bc7006862 () from toorop/golang
Pulling 6a667a081302b8c50169b030f06bcce53ba9c48c8d4e82293f4dab4bc7006862 metadata
Pulling 6a667a081302b8c50169b030f06bcce53ba9c48c8d4e82293f4dab4bc7006862 fs layer
Downloading 22439474/? (n/a)
Error while retrieving image for tag:  (exit status 2: tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Ignoring unknown extended header keyword `SCHILY.fflags'
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
); checking next endpoint
2013/06/18 19:37:32 Could not find repository on any of the indexed registries.

@vieux

vieux commented Jun 18, 2013

Copy link
Copy Markdown
Contributor

@creack if you think it's unrelated, LGTM

@creack

creack commented Jun 18, 2013

Copy link
Copy Markdown
Contributor Author

@vieux, I think it is not related. The image is heavy, probably just a transfert issue.

creack added a commit that referenced this pull request Jun 19, 2013
@creack
Merge pull request #885 from dotcloud/remove_bsdtar
ee5df76 
* Runtime: Remove bsdtar dependency
@creack creack merged commit ee5df76 into master Jun 19, 2013
@creack creack deleted the remove_bsdtar branch June 19, 2013 00:24
@fujin

fujin commented Jun 19, 2013

Copy link
Copy Markdown

🤘

@creack creack mentioned this pull request Jun 21, 2013
Closed
@sanimej sanimej mentioned this pull request Jan 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bsdtar: Failed to set file flags

6 participants

@creack @vieux @shykes @jpetazzo @unclejack @fujin