Skip to content

Remove sqlite dependency#30208

Merged
cpuguy83 merged 2 commits intomoby:masterfrom
justincormack:no-sqlite
Jan 18, 2017
Merged

Remove sqlite dependency#30208
cpuguy83 merged 2 commits intomoby:masterfrom
justincormack:no-sqlite

Conversation

@justincormack
Copy link
Copy Markdown
Contributor

@justincormack justincormack commented Jan 17, 2017 •
edited by thaJeztah
Loading

fixes #22146
relates to #16032

Rebase of #25782 cc @LK4D4

  • What I did
    Removed sqlite dependency.
  • How I did it
    Removed every usage of graphdb.
  • How to verify it
    Compile daemon
  • Description for the changelog

Dependency from sqlite removed, so links upgrade from 1.9 does not work. External migration tool should be used if necessary.

cutest-cat-picture-ever

@justincormack justincormack force-pushed the no-sqlite branch 2 times, most recently from 32aba63 to a0806aa Compare January 17, 2017 13:13
@LK4D4 @justincormack
daemon: remove graphdb usage
b0f9958 
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jan 17, 2017

SGTM.
Maybe we should add a note to the changelog about not being able to upgrade directly from <= 1.9... or maybe just something like *note*: It is recommended to upgrade only one version at a time

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jan 17, 2017

Maybe we should add a warning to logs if old links DB exists. It doesn't require SQLite and small enough I think.

@cpuguy83
Copy link
Copy Markdown
Member

cpuguy83 commented Jan 17, 2017

Well, we kept the db around in case ppl wanted to rollback.

tophj-ibm
tophj-ibm reviewed Jan 17, 2017
View reviewed changes
contrib/builder/deb/amd64/generate.sh Outdated
Copy link
Copy Markdown
Contributor

@tophj-ibm tophj-ibm Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to remove it from all the other builders we have now too.

Copy link
Copy Markdown
Contributor Author

@justincormack justincormack Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I thought I had but you are right it didn't actually generate them as I was on amd64...

Copy link
Copy Markdown
Contributor Author

@justincormack justincormack Jan 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added these.

@justincormack justincormack force-pushed the no-sqlite branch 2 times, most recently from efb4f88 to fd540de Compare January 17, 2017 17:23
@tophj-ibm tophj-ibm mentioned this pull request Jan 17, 2017
Merged
@thaJeztah thaJeztah added this to the 1.14.0 milestone Jan 17, 2017
@justincormack
Remove sqlite
f8119bb 
This drops support for migrations from pre-1.10 Docker versions, which
should be done via an external tool or an intermediate upgrade.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
@justincormack
Copy link
Copy Markdown
Contributor Author

justincormack commented Jan 18, 2017

re-pushed to unstick CI

@LK4D4
Copy link
Copy Markdown
Contributor

LK4D4 commented Jan 18, 2017

Ok, design looks good to me
ping @docker/core-maintainers for move to code-review

LK4D4
LK4D4 approved these changes Jan 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@LK4D4 LK4D4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Jan 18, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 0e8c7d7 into moby:master Jan 18, 2017
@thaJeztah thaJeztah mentioned this pull request Jul 16, 2019
Closed
@thaJeztah thaJeztah mentioned this pull request Sep 26, 2019
Merged
@kolyshkin kolyshkin mentioned this pull request May 1, 2020
Merged
@tianyuanhao tianyuanhao mentioned this pull request Feb 8, 2022
Closed
paralin pushed a commit to skiffos/buildroot that referenced this pull request Feb 21, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
8a2e8b7 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Feb 21, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
b797553 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Feb 21, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
7436fe0 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Feb 22, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
4c31e7d 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Feb 22, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
8b57e35 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Mar 1, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
17e8c63 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Mar 1, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
5d45317 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Mar 4, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
435cac7 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
paralin pushed a commit to skiffos/buildroot that referenced this pull request Mar 7, 2022
@tianyuanhao @paralin
package/docker-engine: remove unused sqlite
89f0a94 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
woodsts pushed a commit to woodsts/buildroot that referenced this pull request Mar 7, 2022
@tianyuanhao @jacmet
package/docker-engine: remove unused sqlite
6105ad3 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this pull request Mar 17, 2022
@tianyuanhao @jacmet
package/docker-engine: remove unused sqlite
56c9ec5 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit 6105ad3)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update pushed a commit to buildroot/buildroot that referenced this pull request Mar 17, 2022
@tianyuanhao @jacmet
package/docker-engine: remove unused sqlite
812e795 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
(cherry picked from commit 6105ad3)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
ccrisan pushed a commit to ccrisan/thingos that referenced this pull request Jun 26, 2025
@tianyuanhao @ccrisan
package/docker-engine: remove unused sqlite
366f965 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
ccrisan pushed a commit to qtoggle/qtoggleos that referenced this pull request Oct 21, 2025
@tianyuanhao @ccrisan
package/docker-engine: remove unused sqlite
3e7166b 
Dependency on sqlite has been removed since v17.04.0-ce.

See: moby/moby#30208

Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
Reviewed-by: Christian Stewart <christian@paral.in>
Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

+2 more reviewers

@tophj-ibm tophj-ibm tophj-ibm left review comments

@LK4D4 LK4D4 LK4D4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

impact/changelog status/2-code-review

Projects

None yet

Milestone

17.04.0

Development

Successfully merging this pull request may close these issues.

RFC: deprecate old graphdb migration / move to an external tool?

7 participants

@justincormack @cpuguy83 @LK4D4 @tophj-ibm @icecrime @thaJeztah @GordonTheTurtle