Shortly after we moved to Go 1.5, I looked into why compiles too so long. I found that a significant amount of the time was spent building sqlite. The Go compilation was parallelized, but the C compilation was not since sqlite is one big file.

Removing sqlite will probably have a beneficial impact on build times.

(That is, the time to build Docker, not the build subcommand.)

I remember we discussed this before, and there was some reluctance, but
definitely worth discussing again...

On 17 Aug 2016 5:59 a.m., "Aaron Lehmann" notifications@github.com wrote:

(That is, the time to build Docker, not the build subcommand.)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#25782 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdcPAuYvNQrkDyXCKQTD4MqwRhpn86mks5qgpU-gaJpZM4Jl_Yb
.

See this issue #22146

ping @cpuguy83 ptal

Oh man, major +1 here.
Thanks for writing the migration tool.

oh! I miss the migration tool, that is really awesome! Would be great if we had that under the "docker" organization - but guess we won't be able to ship it as an image (like the v1.10 migration tool). FWIW, once we're in docs review, I think we should have it added to https://github.com/docker/docker/blob/master/docs/migration.md

@thaJeztah I think we can incorporate that to migrator tool.

I'm also definitely +1 on that 😻

@tonistiigi also pointed that we should notify people that they should run migration tool. Not sure how to make that behavior opt-out though.

Nice! @jstarks FYI

btw compile time goes from 50s to 40s on my machine without sqlite.

I guess my only real concern is that there is still a large contingent of people running docker 1.9 due to build caching issues in >= 1.10.
How many of those people are using --link that would be affected by this?

@cpuguy83 what do you think? Should we move this to 1.14? Or don't do it at all?

@cpuguy83 or shall we document that people from 1.9 should always use 1.10, perhaps we should check if we document that we support upgrading and skipping versions?

If so, then I think we can move forward

@thaJeztah Do people read docs before upgrading?
I'm just worried we are going to break people, especially when there are so many on 1.9 still.

@thaJeztah @cpuguy83 yeah, let's wait for a release with caching improvements, so people can upgrade. I'll close this for now.

Thanks!