Add --tty to docker service create/update
#28076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
LGTM |
Member
|
Just a quick check; if we want to add this to
We should have a look at that before going forward with this, so that we don't lock ourselves in |
This is how it should work. As a rule, |
|
The changes so far look good, but this PR should also add |
Member
|
@aaronlehmann ah yes you're right, thanks! And i agree, we should have it in update as well |
72acbea to
9f03a40
Compare
--tty to docker service create--tty to docker service create/update
Member
Author
|
Thanks @thaJeztah @aaronlehmann. The PR has been updated with |
Member
Author
|
The behavior of
|
aaronlehmann
reviewed
Nov 5, 2016
cli/command/service/opts.go
Outdated
aaronlehmann
reviewed
Nov 5, 2016
cli/command/service/update.go
Outdated
aaronlehmann
reviewed
Nov 5, 2016
aaronlehmann
reviewed
Nov 5, 2016
aaronlehmann
reviewed
Nov 5, 2016
There was a problem hiding this comment.
Pull out this shell code into a variable so it can be reused.
9f03a40 to
0c086c8
Compare
Member
Author
|
Thanks @aaronlehmann for the review. Comments have been addressed. Please take a look and let me know if there are other issues. |
thaJeztah
approved these changes
Nov 7, 2016
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks!
/cc @albers @sdurrheimer for completion scripts :)
Member
|
@yongtang I guess this needs an update to the API docs (and API changes for 1.25) as well, can you include those changes in this PR? |
Member
Author
|
@thaJeztah Sure let me update the PR shortly. |
0c086c8 to
9c21521
Compare
Member
Author
|
@thaJeztah The PR has been updated with doc changes. Please take a look. |
This fix tries to add `--tty` to `docker service create/update`. As was specified in 25644, `TTY` flag has been added to SwarmKit and is already vendored. This fix add `--tty` to `docker service create/update`. Related document has been updated. Additional integration tests has been added. This fix fixes 25644. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
9c21521 to
599be5a
Compare
Member
Author
|
@thaJeztah Updated docs again for examples 😅 |
Member
|
Perfect, thank you! |
Contributor
|
LGTM |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 16, 2017
Pull request moby#27745 added support for the client to talk to older versions of the daemon. Various flags were added to docker 1.13 that are not compatible with older daemons. This PR adds annotations to those flags, so that they are automatically hidden if the daemon is older than docker 1.13 (API 1.25). Not all new flags affect the API (some are client-side only). The following PR's added new flags to docker 1.13 that affect the API; - moby#23430 added `--cpu-rt-period`and `--cpu-rt-runtime` - moby#27800 / moby#25317 added `--group` / `--group-add` / `--group-rm` - moby#27702 added `--network` to `docker build` - moby#25962 added `--attachable` to `docker network create` - moby#27998 added `--compose-file` to `docker stack deploy` - moby#22566 added `--stop-timeout` to `docker run` and `docker create` - moby#26061 added `--init` to `docker run` and `docker create` - moby#26941 added `--init-path` to `docker run` and `docker create` - moby#27958 added `--cpus` on `docker run` / `docker create` - moby#27567 added `--dns`, `--dns-opt`, and `--dns-search` to `docker service create` - moby#27596 added `--force` to `docker service update` - moby#27857 added `--hostname` to `docker service create` - moby#28031 added `--hosts`, `--host-add` / `--host-rm` to `docker service create` and `docker service update` - moby#28076 added `--tty` on `docker service create` / `docker service update` - moby#26421 added `--update-max-failure-ratio`, `--update-monitor` and `--rollback` on `docker service update` - moby#27369 added `--health-cmd`, `--health-interval`, `--health-retries`, `--health-timeout` and `--no-healthcheck` options to `docker service create` and `docker service update` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 19, 2017
Pull request moby/moby#27745 added support for the client to talk to older versions of the daemon. Various flags were added to docker 1.13 that are not compatible with older daemons. This PR adds annotations to those flags, so that they are automatically hidden if the daemon is older than docker 1.13 (API 1.25). Not all new flags affect the API (some are client-side only). The following PR's added new flags to docker 1.13 that affect the API; - moby/moby#23430 added `--cpu-rt-period`and `--cpu-rt-runtime` - moby/moby#27800 / moby/moby#25317 added `--group` / `--group-add` / `--group-rm` - moby/moby#27702 added `--network` to `docker build` - moby/moby#25962 added `--attachable` to `docker network create` - moby/moby#27998 added `--compose-file` to `docker stack deploy` - moby/moby#22566 added `--stop-timeout` to `docker run` and `docker create` - moby/moby#26061 added `--init` to `docker run` and `docker create` - moby/moby#26941 added `--init-path` to `docker run` and `docker create` - moby/moby#27958 added `--cpus` on `docker run` / `docker create` - moby/moby#27567 added `--dns`, `--dns-opt`, and `--dns-search` to `docker service create` - moby/moby#27596 added `--force` to `docker service update` - moby/moby#27857 added `--hostname` to `docker service create` - moby/moby#28031 added `--hosts`, `--host-add` / `--host-rm` to `docker service create` and `docker service update` - moby/moby#28076 added `--tty` on `docker service create` / `docker service update` - moby/moby#26421 added `--update-max-failure-ratio`, `--update-monitor` and `--rollback` on `docker service update` - moby/moby#27369 added `--health-cmd`, `--health-interval`, `--health-retries`, `--health-timeout` and `--no-healthcheck` options to `docker service create` and `docker service update` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 5d2722f83db9e301c6dcbe1c562c2051a52905db Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This fix tries to add
--ttytodocker service create/update. As was specified in #25644,TTYflag has been added to SwarmKit and is already vendored.- How I did it
This fix add
--ttytodocker service create/update.Related document has been updated.
- How to verify it
Additional integration tests has been added.
- Description for the changelog
Add
--ttyflag todocker service create/update.- A picture of a cute animal (not mandatory but encouraged)
This fix fixes #25644.
Signed-off-by: Yong Tang yong.tang.github@outlook.com