Support --group in docker service create
#25317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4f2817 to
bbb9d4c
Compare
Member
|
Can you rename this to |
bbb9d4c to
fce2de3
Compare
Member
Author
|
Thanks @thaJeztah. The pull request has been updated. Please let me know if there are any issues. |
api/client/service/opts.go
Outdated
Member
There was a problem hiding this comment.
-1 on the -g.
Could use some extra description. "Add additional groups to the container"
c83581e to
9a113ee
Compare
Member
|
LGTM 🐸 |
api/client/service/update.go
Outdated
Member
There was a problem hiding this comment.
I don't think we need to mess with EndpointSpec here.
Member
Author
There was a problem hiding this comment.
@cpuguy83 Sorry my bad. Didn't pay attention. Let me update the pull request.
9a113ee to
3af251f
Compare
Member
Author
|
Thanks @cpuguy83. The pull request has been updated. Please let me know if there are any issues. |
Member
|
LGTM |
Member
|
moved to docs review |
Member
Author
|
Thanks @cpuguy83. The docs has been updated for |
Member
|
Thanks @yongtang |
880e2a4 to
0e680bb
Compare
Member
Author
|
Thanks @cpuguy83. The pull request has been updated. |
Member
|
ping @vdemeester |
api/client/service/update.go
Outdated
Member
There was a problem hiding this comment.
"Remove previously added user groups from the container"?
Not sure how to say this one... just a suggestion. Both sound weird.
Member
Author
There was a problem hiding this comment.
Thanks @cpuguy83. The pull request has been updated with the help output "Remove previously added user groups from the container" for now. Let me know if there are other suggestions.
This fix tries to address the issue raised in 25304 to support `--group-add` and `--group-rm` in `docker service create`. This fix adds `--group-add` to `docker service create` and `docker service update`, adds `--group-rm` to `docker service update`. This fix updates docs for `docker service create` and `docker service update`: 1. Add `--group-add` to `docker service create` and `docker service update` 2. Add `--group-rm` to `docker service update` Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
0e680bb to
b31969e
Compare
Member
|
docs LGTM 🐯 |
Member
|
LGTM |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 16, 2017
Pull request moby#27745 added support for the client to talk to older versions of the daemon. Various flags were added to docker 1.13 that are not compatible with older daemons. This PR adds annotations to those flags, so that they are automatically hidden if the daemon is older than docker 1.13 (API 1.25). Not all new flags affect the API (some are client-side only). The following PR's added new flags to docker 1.13 that affect the API; - moby#23430 added `--cpu-rt-period`and `--cpu-rt-runtime` - moby#27800 / moby#25317 added `--group` / `--group-add` / `--group-rm` - moby#27702 added `--network` to `docker build` - moby#25962 added `--attachable` to `docker network create` - moby#27998 added `--compose-file` to `docker stack deploy` - moby#22566 added `--stop-timeout` to `docker run` and `docker create` - moby#26061 added `--init` to `docker run` and `docker create` - moby#26941 added `--init-path` to `docker run` and `docker create` - moby#27958 added `--cpus` on `docker run` / `docker create` - moby#27567 added `--dns`, `--dns-opt`, and `--dns-search` to `docker service create` - moby#27596 added `--force` to `docker service update` - moby#27857 added `--hostname` to `docker service create` - moby#28031 added `--hosts`, `--host-add` / `--host-rm` to `docker service create` and `docker service update` - moby#28076 added `--tty` on `docker service create` / `docker service update` - moby#26421 added `--update-max-failure-ratio`, `--update-monitor` and `--rollback` on `docker service update` - moby#27369 added `--health-cmd`, `--health-interval`, `--health-retries`, `--health-timeout` and `--no-healthcheck` options to `docker service create` and `docker service update` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
May 19, 2017
Pull request moby/moby#27745 added support for the client to talk to older versions of the daemon. Various flags were added to docker 1.13 that are not compatible with older daemons. This PR adds annotations to those flags, so that they are automatically hidden if the daemon is older than docker 1.13 (API 1.25). Not all new flags affect the API (some are client-side only). The following PR's added new flags to docker 1.13 that affect the API; - moby/moby#23430 added `--cpu-rt-period`and `--cpu-rt-runtime` - moby/moby#27800 / moby/moby#25317 added `--group` / `--group-add` / `--group-rm` - moby/moby#27702 added `--network` to `docker build` - moby/moby#25962 added `--attachable` to `docker network create` - moby/moby#27998 added `--compose-file` to `docker stack deploy` - moby/moby#22566 added `--stop-timeout` to `docker run` and `docker create` - moby/moby#26061 added `--init` to `docker run` and `docker create` - moby/moby#26941 added `--init-path` to `docker run` and `docker create` - moby/moby#27958 added `--cpus` on `docker run` / `docker create` - moby/moby#27567 added `--dns`, `--dns-opt`, and `--dns-search` to `docker service create` - moby/moby#27596 added `--force` to `docker service update` - moby/moby#27857 added `--hostname` to `docker service create` - moby/moby#28031 added `--hosts`, `--host-add` / `--host-rm` to `docker service create` and `docker service update` - moby/moby#28076 added `--tty` on `docker service create` / `docker service update` - moby/moby#26421 added `--update-max-failure-ratio`, `--update-monitor` and `--rollback` on `docker service update` - moby/moby#27369 added `--health-cmd`, `--health-interval`, `--health-retries`, `--health-timeout` and `--no-healthcheck` options to `docker service create` and `docker service update` Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 5d2722f83db9e301c6dcbe1c562c2051a52905db Component: cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This fix tries to address the issue raised in #25304 to support
--groupindocker service create.- How I did it
This fix adds
--grouptodocker service create, and addsGroup []stringto ContainerSpec in engine-api and swarmkit for the needed changes.The
ConfigandHostConfigin container remain the same formats. The groups are appended toHostConfig.GroupAddif needed.- How to verify it
An additional integration test has bee added.
- Description for the changelog
Support
--groupindocker service create- A picture of a cute animal (not mandatory but encouraged)
This fix fixes #25304.
NOTE: PRs for engine-api and swarmkit will be opened separately
Signed-off-by: Yong Tang yong.tang.github@outlook.com