Skip to content

hack/make/test-unit: support coverprofile#22930

Closed
AkihiroSuda wants to merge 1 commit intomoby:masterfrom
AkihiroSuda:coverprofile
Closed

hack/make/test-unit: support coverprofile#22930
AkihiroSuda wants to merge 1 commit intomoby:masterfrom
AkihiroSuda:coverprofile

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented May 24, 2016

- What I did
Support coverprofiles for hack/make/test-unit.

- How I did it
test-integration-cli uses go_test_dir for fetching the coverprofile.
Now test-unit utilizes go_test_dir as well.

- How to verify it

$ make test-unit
$ ls bundles/latest/test-unit/coverprofiles/
docker-api
docker-api-client
...

- Description for the changelog

Update #22899

TODOs suggested in #22899 (should be done in separate PRs after merging this PR)

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

@AkihiroSuda AkihiroSuda mentioned this pull request May 24, 2016
Closed
@AkihiroSuda AkihiroSuda force-pushed the coverprofile branch 2 times, most recently from c33025e to bd693cc Compare May 24, 2016 07:08
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented May 24, 2016

The test failures seems related to my change. I'll look into this.

@AkihiroSuda AkihiroSuda mentioned this pull request May 24, 2016
Closed
@thaJeztah thaJeztah added the status/failing-ci Indicates that the PR in its current state fails the test suite label May 24, 2016
This was referenced May 25, 2016
Closed
Closed
Closed
Closed
@GordonTheTurtle GordonTheTurtle added the dco/no Automatically set by a bot when one of the commits lacks proper signature label May 30, 2016
@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label May 30, 2016
@AkihiroSuda AkihiroSuda mentioned this pull request May 31, 2016
Closed
@thaJeztah
Copy link
Member

thaJeztah commented May 31, 2016

The TestJSONFormatProgress should be fixed now in #23113, so restarting CI

@thaJeztah thaJeztah added status/2-code-review and removed status/failing-ci Indicates that the PR in its current state fails the test suite status/0-triage labels May 31, 2016
@thaJeztah
Copy link
Member

thaJeztah commented May 31, 2016

boo. looks like CI doesn't want to restart, @AkihiroSuda can you try rebasing and pushing again?

@AkihiroSuda AkihiroSuda mentioned this pull request Jun 1, 2016
Closed
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jun 1, 2016

@thaJeztah OK, but I need to wait for #23120, #23152, and LLVM apt issue

@icecrime icecrime added the status/failing-ci Indicates that the PR in its current state fails the test suite label Jun 1, 2016
@AkihiroSuda AkihiroSuda force-pushed the coverprofile branch 3 times, most recently from 3105159 to 7b99373 Compare June 3, 2016 04:16
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jun 3, 2016

@thaJeztah I think the PR is ready for review. The failure in win2lin seems not related to my change.

Note that the build time seems getting longer 😞
e.g. experimental took 1h35min https://jenkins.dockerproject.org/job/Docker-PRs-experimental/19367/

Maybe we can solve this performance regression by disabling go test -c and just doing go test $someflags at once for multiple packages.

@thaJeztah thaJeztah removed the status/failing-ci Indicates that the PR in its current state fails the test suite label Jun 3, 2016
@thaJeztah
Copy link
Member

thaJeztah commented Jun 3, 2016

Thanks! I removed the "failing-ci" label and restarted win2lin.

Yes, the tests are really getting long, perhaps we should consider something like that to see if it helps speeding up

@thaJeztah
Copy link
Member

thaJeztah commented Jun 7, 2016

ping @vdemeester @justincormack could you have a look at this one?

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jun 9, 2016

Amended the PR so as to compile test binaries at once for multiple packages.
See if it works..

@thaJeztah
Copy link
Member

thaJeztah commented Jun 9, 2016

Hm, something's failing;

11:42:00 ---> Making bundle: .ensure-nnp-test (in bundles/1.12.0-dev/test-integration-cli)
11:42:12 can't load package: package github.com/docker/docker: no buildable Go source files in /go/src/github.com/docker/docker

@thaJeztah thaJeztah added the status/failing-ci Indicates that the PR in its current state fails the test suite label Jun 9, 2016
@AkihiroSuda
hack/make/test-unit: support coverprofile
4f40165 
e.g. for github.com/docker/api, the coverprofile is located on bundles/latest/test-unit/coverprofiles/docker-api

Update moby#22899

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@thaJeztah thaJeztah removed the status/failing-ci Indicates that the PR in its current state fails the test suite label Jun 14, 2016
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jun 14, 2016

CI is passing, but I found that no coverprofile for integration-test is generated.. perhaps related to the handling of -args for go test...

Sorry for failing repeatedly..
Closing the PR temporarily.
I will reopen when the code is ready

@thaJeztah
Copy link
Member

thaJeztah commented Jun 14, 2016

@AkihiroSuda no worries, thanks in advance! Looking forward to an updated PR

@AkihiroSuda AkihiroSuda mentioned this pull request Jun 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkihiroSuda @thaJeztah @icecrime @GordonTheTurtle