Fix pkg/jsonmessage.TestProgress panic#23113
Merged
coolljt0725 merged 1 commit intomoby:masterfrom May 31, 2016
Merged
Conversation
Fix moby#23112 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
547f578 to
709478c
Compare
Member
|
Nice :-) |
Contributor
|
LGTM 👍 |
AkihiroSuda
added a commit
to AkihiroSuda/docker
that referenced
this pull request
May 31, 2016
The test was failing if the terminal column width is <= 110. Addendum to moby#23113 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fix pkg/jsonmessage.TestProgress panic (#23112)
- How I did it
Check the terminal window size
- How to verify it
$COLUMNS) to <= 110 so as to confirm pkg/jsonmessage.TestProgress fails depending on TIOCGWINSZ #23112 is resolved$COLUMNS) to > 110 so as to confirm there is no regression.Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp