-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Closed
Description
Steps to reproduce the issue:
$ git config --get core.autocrlf
$ go test ./pkg/gitutils
Tested with 4a7715c
Describe the results you received:
| OS | core.autocrlf | Result |
|---|---|---|
| Linux | true | FAIL |
| Linux | false/unset | PASS |
| Windows | true | PASS |
| Windows | false/unset | FAIL |
failure message:
--- FAIL: TestCheckoutGit (0.04s)
gitutils_test.go:201: Expected FROM scratch
EXPOSE 5000, was FROM scratch
EXPOSE 5000
FAIL
Describe the results you expected:
It should not fail.
Additional information you deem important (e.g. issue happens only occasionally)
- Found in PR hack/make/test-unit: support coverprofile #22930, which is an attempt to simplify go test in hack/*. The PR uses
env -ifortest-unitas well as fortest-integration, so it disables some git-related environment variable. - The cause of the issue is obvious:
eolis not properly set : https://github.com/docker/docker/blob/4a7715c9783627ecc194dac8502a684f40a9d0bd/pkg/gitutils/gitutils_test.go#L80
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels