testing, issue #1948: Increase TestRunDetach timeout#2061
Merged
Conversation
Member
|
I can definitely attest to the fact that this issue currently makes it very hard to take any of the build failure notifications in #docker-testing from the CI server seriously, so this change LGTM. |
Contributor
|
LGTM It will be nice once we have stats on how long tests take to run. Because right now must of the timeout limits are arbitrary. |
Contributor
Author
|
@crosbymichael: That's a great idea! docker-ci report should include it. Do you mind creating a ticket with it and assigning it to me? |
mzdaniel
added a commit
that referenced
this pull request
Oct 6, 2013
testing, issue #1948: Increase TestRunDetach timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production deployments, we are still seen:
--- FAIL: TestRunDetach (5.11 seconds)
commands_test.go:42: Waiting for CmdRun timed out
=== RUN TestAttachDetach
--- FAIL: TestAttachDetach (5.06 seconds)
commands_test.go:42: Waiting for CmdAttach timed ou
http://docker-ci.dotcloud.com/builders/docker/builds/332/steps/shell/logs/stdio
thttp://docker-ci.dotcloud.com/builders/pullrequest/builds/619/steps/shell/logs/stdio