Skip to content

Fix attach issue#1948

Merged
vieux merged 2 commits intomasterfrom
fix_attach
Sep 23, 2013
Merged

Fix attach issue#1948
vieux merged 2 commits intomasterfrom
fix_attach

Conversation

@creack
Copy link
Copy Markdown
Contributor

@creack creack commented Sep 20, 2013

Fixes #1939

@creack
Copy link
Copy Markdown
Contributor Author

creack commented Sep 20, 2013

/cc @crosbymichael @vieux @shykes

@ghost ghost assigned shykes Sep 20, 2013
@keeb-zz
Copy link
Copy Markdown
Contributor

keeb-zz commented Sep 20, 2013

cc @shykes, this issue was automatically assigned to you by Gordon

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Sep 20, 2013

@creack I got 2 errors in the test:

--- FAIL: TestRunDetach (10.03 seconds)
    commands_test.go:42: Waiting for container to die timedout
--- FAIL: TestAttachDetach (10.03 seconds)
    commands_test.go:42: Waiting for container to die timedout

timedout is a typo btw ?

@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented Sep 20, 2013

LGTM

@creack
Copy link
Copy Markdown
Contributor Author

creack commented Sep 20, 2013

@vieux can you try again?

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Sep 23, 2013

LGTM

vieux pushed a commit that referenced this pull request Sep 23, 2013
Merge pull request #1948 from dotcloud/fix_attach
2fafe1e 
Fix attach issue
@vieux vieux merged commit 2fafe1e into master Sep 23, 2013
@creack creack deleted the fix_attach branch September 23, 2013 18:37
@vieux vieux mentioned this pull request Sep 24, 2013
Merged
mzdaniel pushed a commit that referenced this pull request Oct 1, 2013
testing, issue #1948: Increase TestAttachDetach and TestRunDetach tim…
135c1fc 
…eout
mzdaniel pushed a commit that referenced this pull request Oct 5, 2013
testing, issue #1948: Increase TestRunDetach timeout
5e76a1a
mzdaniel added a commit that referenced this pull request Oct 6, 2013
@mzdaniel
Merge pull request #2061 from dotcloud/1948-test-detach
c18e849 
testing, issue #1948: Increase TestRunDetach timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shykes shykes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detach is broken in 0.6.2.

5 participants

@creack @keeb-zz @vieux @crosbymichael @shykes