Fix network inspect for default networks. #17538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
As a note before people freak out: this is embedded, so there won't be any DefaultNetworkSettings key.
Contributor
|
👍 |
Contributor
|
👍 on the design |
564c5ce to
710bec6
Compare
Contributor
Author
|
As discussed, the api 1.20 won't show the default network IP unless the network name is bridge. Please, take another look. |
api/types/versions/v1p20/types.go
Outdated
Contributor
There was a problem hiding this comment.
we dont want Networks here
- Keep old fields in NetworkSetting to respect the deprecation policy. Signed-off-by: David Calavera <david.calavera@gmail.com>
710bec6 to
f301c57
Compare
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Contributor
|
LGTM |
Contributor
|
will start doing the same on swarm |
Contributor
|
I'm adding a test in swarm to make sure we are notified if the output change again https://github.com/vieux/swarm/blob/improve_network_inspect_test/test/integration/api/network.bats#L31 |
abronan
added a commit
that referenced
this pull request
Oct 30, 2015
Fix network inspect for default networks.
Contributor
|
Thanks @abronan |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 286fe69) Conflicts: docs/reference/api/docker_remote_api_v1.22.md
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Nov 15, 2016
When inspecting a container, `NetworkSettings` contains top-level
information about the default ("bridge") network;
`EndpointID`, `Gateway`, `GlobalIPv6Address`, `GlobalIPv6PrefixLen`,
`IPAddress`, `IPPrefixLen`, `IPv6Gateway`, and `MacAddress`.
These properties are deprecated in favor of per-network properties in
`NetworkSettings.Networks`. These properties were already "deprecated" in
docker 1.9, but kept around for backward compatibility.
Refer to [moby#17538](moby#17538) for further
information.
This officially deprecates these properties, and marks them
for removal in 1.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
vieux
pushed a commit
to vieux/docker
that referenced
this pull request
Dec 14, 2016
When inspecting a container, `NetworkSettings` contains top-level
information about the default ("bridge") network;
`EndpointID`, `Gateway`, `GlobalIPv6Address`, `GlobalIPv6PrefixLen`,
`IPAddress`, `IPPrefixLen`, `IPv6Gateway`, and `MacAddress`.
These properties are deprecated in favor of per-network properties in
`NetworkSettings.Networks`. These properties were already "deprecated" in
docker 1.9, but kept around for backward compatibility.
Refer to [moby#17538](moby#17538) for further
information.
This officially deprecates these properties, and marks them
for removal in 1.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit ae6f09b)
Signed-off-by: Victor Vieux <vieux@docker.com>
xianlubird
pushed a commit
to xianlubird/docker
that referenced
this pull request
Dec 23, 2016
When inspecting a container, `NetworkSettings` contains top-level
information about the default ("bridge") network;
`EndpointID`, `Gateway`, `GlobalIPv6Address`, `GlobalIPv6PrefixLen`,
`IPAddress`, `IPPrefixLen`, `IPv6Gateway`, and `MacAddress`.
These properties are deprecated in favor of per-network properties in
`NetworkSettings.Networks`. These properties were already "deprecated" in
docker 1.9, but kept around for backward compatibility.
Refer to [moby#17538](moby#17538) for further
information.
This officially deprecates these properties, and marks them
for removal in 1.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jun 5, 2017
When inspecting a container, `NetworkSettings` contains top-level
information about the default ("bridge") network;
`EndpointID`, `Gateway`, `GlobalIPv6Address`, `GlobalIPv6PrefixLen`,
`IPAddress`, `IPPrefixLen`, `IPv6Gateway`, and `MacAddress`.
These properties are deprecated in favor of per-network properties in
`NetworkSettings.Networks`. These properties were already "deprecated" in
docker 1.9, but kept around for backward compatibility.
Refer to [#17538](moby/moby#17538) for further
information.
This officially deprecates these properties, and marks them
for removal in 1.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 96d5009f10860bb8d58b1cf80d239f2288c0784e
Component: cli
dnephin
pushed a commit
to dnephin/cli
that referenced
this pull request
Jun 14, 2017
When inspecting a container, `NetworkSettings` contains top-level
information about the default ("bridge") network;
`EndpointID`, `Gateway`, `GlobalIPv6Address`, `GlobalIPv6PrefixLen`,
`IPAddress`, `IPPrefixLen`, `IPv6Gateway`, and `MacAddress`.
These properties are deprecated in favor of per-network properties in
`NetworkSettings.Networks`. These properties were already "deprecated" in
docker 1.9, but kept around for backward compatibility.
Refer to [#17538](moby/moby#17538) for further
information.
This officially deprecates these properties, and marks them
for removal in 1.16
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tiborvass, @mavenugo please, take a look.
Fixes #17494
Signed-off-by: David Calavera david.calavera@gmail.com