Correct API docs for /images/create #17085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Nephin <dnephin@docker.com>
84ba3f0 to
2ec4404
Compare
Member
|
/ping @thaJeztah @moxiegirl |
Contributor
|
LGTM Thank you @dnephin for the catch. |
Member
|
Thanks @dnephin LGTM 👍 |
thaJeztah
added a commit
that referenced
this pull request
Oct 16, 2015
Correct API docs for /images/create
Member
|
Oh, @dnephin forgot that you wanted to copy it to the API v1.20 docs 😊 let me know if you want to pick that up or want us to do that for you |
Member
Author
|
I'm not entirely sure how far back it needs to ported, it's probably not entirely necessary. |
Member
|
np, we can fix that later (not sure when these changed) |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 286fe69) Conflicts: docs/reference/api/docker_remote_api_v1.22.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API docs for this endpoint are incomplete and from what I can tell just wrong in one case.
registryparam. Maybe it was removed at some point?fromImageor intagI think these fixes could probably be backported to the 1.20 api docs as well, but I wanted to get a review of the wording first, then I can copy it.
+kind/docs