LGTM
Does open the door for major optimizations on v1.

ping @tianon bc i know you liked this feature but we may as well be consistent

😢 but fair. Does this also prevent docker from querying all the tags from the registry? That was the reason this came up again.

/me sheds some tears 😢

If we're not getting it in v2 though, let's remove it for sure.

/me shares hanky with @tianon

@thaJeztah no -- @jfrazelle coded this feature up originally just because we were already receiving the data for all tags, regardless of only having pulled one, so it was trivial to implement

Yes, that was what I thought at the time, but #10563 mentions that because of this all tags are queried in the registry. Reading this change again, doesn't seem to solve that?

It allows the registry team to implement some enhancements so maybe we
don't get data on all tags anymore, the feature however did not originally include
that, I could look into how to possibly remove it but am not as familiar

On Wed, Feb 4, 2015 at 4:12 PM, Tianon Gravi notifications@github.com
wrote:

@thaJeztah https://github.com/thaJeztah no -- @jfrazelle
https://github.com/jfrazelle coded this feature up originally just
because we were already receiving the data for all tags, regardless of only
having pulled one, so it was trivial to implement

—
Reply to this email directly or view it on GitHub
#10571 (comment).

you can see the original PR was #8193

On Wed, Feb 4, 2015 at 4:16 PM, Jessica Frazelle jess@docker.com wrote:

It allows the registry team to implement some enhancements so maybe we
don't pull all tags anymore, the feature however did not originally include
that, I could look into how to possibly remove it but am not as familiar

On Wed, Feb 4, 2015 at 4:12 PM, Tianon Gravi notifications@github.com
wrote:

@thaJeztah https://github.com/thaJeztah no -- @jfrazelle
https://github.com/jfrazelle coded this feature up originally just
because we were already receiving the data for all tags, regardless of only
having pulled one, so it was trivial to implement

—
Reply to this email directly or view it on GitHub
#10571 (comment).

We were pulling information on all tags regardless of the feature being
implemented. Just to clear that up.

On Wed, Feb 4, 2015 at 4:17 PM, Jessica Frazelle jess@docker.com wrote:

you can see the original PR was #8193

On Wed, Feb 4, 2015 at 4:16 PM, Jessica Frazelle jess@docker.com wrote:

It allows the registry team to implement some enhancements so maybe we
don't pull all tags anymore, the feature however did not originally include
that, I could look into how to possibly remove it but am not as familiar

On Wed, Feb 4, 2015 at 4:12 PM, Tianon Gravi notifications@github.com
wrote:

@thaJeztah https://github.com/thaJeztah no -- @jfrazelle
https://github.com/jfrazelle coded this feature up originally just
because we were already receiving the data for all tags, regardless of only
having pulled one, so it was trivial to implement

—
Reply to this email directly or view it on GitHub
#10571 (comment).

Perhaps #10563 shouldn't be closed then (it may have to be re-worded), because that is about hitting the registry to fetch all tags and images in the repository (which won't be solved by this PR)

ok i reopened it

On Wed, Feb 4, 2015 at 4:23 PM, Sebastiaan van Stijn <
notifications@github.com> wrote:

Perhaps #10563 #10563 shouldn't
be closed then (it may have to be re-worded), because that is about hitting
the registry to fetch all tags and images in the repository (which won't be
solved by this PR)

—
Reply to this email directly or view it on GitHub
#10571 (comment).

Thanks! Just to prevent it getting out of sight

🚢

It would be awesome to see this in 1.5.0.

ping @icecrime @crosbymichael :D

LGTM

@jfrazelle is it going to be included in 1.5.1?