Pull all image aliases for id by jessfraz · Pull Request #8193 · moby/moby

jessfraz · 2014-09-23T23:02:10Z

Pull all image aliases for id.
Closes #8141.

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle jess@docker.com (github: jfrazelle)

tiborvass · 2014-09-23T23:04:53Z

@jfrazelle can I haz test, please? :)

jessfraz · 2014-09-23T23:05:22Z

ya I am thinking about the best way without waiting for a huge image to download

jessfraz · 2014-09-23T23:39:20Z

ok @tiborvass test added

SvenDowideit · 2014-09-23T23:43:22Z

I presume this needs docs updates?

jessfraz · 2014-09-23T23:48:59Z

@SvenDowideit added something, a bit unsure about wording

tiborvass · 2014-09-24T00:19:51Z

integration-cli/docker_cli_pull_test.go

s/my/jess's/

tiborvass · 2014-09-24T00:21:02Z

@unclejack @LK4D4 if you guys have better ideas for the test. Do you think we should add a test relying on internet or should we not have a test for now?

crosbymichael · 2014-09-24T00:28:59Z

I would rather skip the test than rely on network

LK4D4 · 2014-09-24T07:02:28Z

Actually I think our tests not work without network anyway now :/ Pull tests in particular test pull on central registry.

tiborvass · 2014-09-24T14:32:22Z

Okay, then apologies @jfrazelle :S Maybe we should just put a FIXME to remind us to put a test.

jessfraz · 2014-09-24T17:32:42Z

np! i will update

jessfraz · 2014-09-24T17:35:18Z

updated!

thaJeztah · 2014-09-24T18:01:16Z

First of all, thanks for picking this up, Jessie, much appreciated!

I've got a couple of remarks/questions

By opening this issue, I introduced a new term; "alias". While I think this is okay, it may be confusing for Mac OS X users (an "alias" on OS X is similar to a "shortcut (Windows)" / "symlink (Linux)"). Probably have the doc maintainers give that a green light.
Does this PR also cover cases where docker pull is not explicitly called, ie when the pull is triggered from a Dockerfile FROM image:tag instruction? My concern here is that this would still leave the opportunity that "aliases" get "out of sync"
In a broader perspective; should a API pull produce the same result? If so, maybe this change should be moved to the API, so that tools like (for example) fig would keep aliased images in sync as well (and reduce the chance that images get out of sync)

(Note; I'm not a Go-programmer, I try to follow the code changes, but I may of course have interpreted them incorrectly :))

jessfraz · 2014-09-24T18:04:42Z

I think @SvenDowideit or one of the other docs maintainers will be able to say if "alias" is the right term
Yes, pulling via a Dockerfile would also pull aliases, because the changes were made to the pull action, and not the command line specifically.
Remote API pull would perform the same as well and pull all aliases.

thaJeztah · 2014-09-24T18:09:23Z

Well, erm, then, let me summarise ....... Awesome!

Yup, that about covers it 😸

vieux · 2014-09-25T00:24:29Z

LGTM

tiborvass · 2014-09-25T00:27:08Z

integration-cli/docker_cli_pull_test.go

Can you just add the issue number ? #8141

SvenDowideit · 2014-09-25T01:21:45Z

I would love to ditch the repository:tag words in favour of alias in many cases, so +1 to that.

(and this PR/feature is exactly why - its just a label, not anything like git add to a repo.)

Doc LGTM - @jamtur01 @fredlf @ostezer

jamtur01 · 2014-09-25T01:24:07Z

Docs LGTM

tiborvass · 2014-09-25T15:36:35Z

docs/sources/reference/commandline/cli.md

will this debian:testing == debian:jessie always hold true? If not, I'd prefer an example that will always be true.

That's not even true right now, let alone in the future...

Lol I can fix it
On Sep 25, 2014 8:38 AM, "Tianon Gravi" notifications@github.com wrote:

In docs/sources/reference/commandline/cli.md:

$ sudo docker pull debian:testing

will pull only the image named debian:testing and any intermediate layers

it is based on. (Typically the empty scratch image, a MAINTAINER layer,

will pull the image named debian:testing, debian:jessie

That's not even true right now, let alone in the future...

—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/8193/files#r18039420.

i don't know what a good example would be that wouldn't become obsolete at some point.

Maybe "trusty" and "14.04"? It will become obsolete eventually, but won't
ever be incorrect.

ah genius changing!!

fredlf · 2014-09-25T18:44:40Z

I'm fine with "alias". I tried, but I can't think of a better term. LGTM from docs.

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)

tiborvass · 2014-09-25T19:22:07Z

LGTM

…or-id Pull all image aliases for id

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch 3 times, most recently from db2d75e to 3d0e55e Compare September 23, 2014 23:38

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from 3d0e55e to b49d1fc Compare September 23, 2014 23:48

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from b49d1fc to 246e443 Compare September 23, 2014 23:51

tiborvass reviewed Sep 24, 2014
View reviewed changes

integration-cli/docker_cli_pull_test.go Outdated

Copy link
Copy Markdown

Contributor

tiborvass Sep 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/my/jess's/

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from 246e443 to 07e5b98 Compare September 24, 2014 00:31

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from 07e5b98 to 718530a Compare September 24, 2014 17:34

tiborvass reviewed Sep 25, 2014
View reviewed changes

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from 718530a to 0f5ce35 Compare September 25, 2014 00:28

tiborvass reviewed Sep 25, 2014
View reviewed changes

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from 0f5ce35 to 62d3245 Compare September 25, 2014 17:12

Pull all image aliases for id. Closes moby#8141.

7d74be1

Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <jess@docker.com> (github: jfrazelle)

jessfraz force-pushed the 8141-pull-all-image-aliases-for-id branch from 62d3245 to 7d74be1 Compare September 25, 2014 18:48

tiborvass added a commit that referenced this pull request Sep 25, 2014

Merge pull request #8193 from jfrazelle/8141-pull-all-image-aliases-f…

1379c6e

…or-id Pull all image aliases for id

tiborvass merged commit 1379c6e into moby:master Sep 25, 2014

jessfraz deleted the 8141-pull-all-image-aliases-for-id branch October 10, 2014 03:14

tianon mentioned this pull request Oct 21, 2014

"docker pull library-image:tag" doesn't pull all aliases #8689

Closed

dustinlacewell mentioned this pull request Nov 26, 2014

Do Not pull all image aliases for id #9373

Closed

bacongobbler mentioned this pull request Dec 8, 2014

Modify Dockerfiles with each release deis/deis#2568

Closed

thaJeztah mentioned this pull request May 3, 2017

Docker pull image:tag should pull all "aliases" #8141

Closed

thaJeztah mentioned this pull request Oct 25, 2024

[RFC] consider changing meaning of "--all-tags" to "all tags for the same image" #48760

Open

Conversation

jessfraz commented Sep 23, 2014

Uh oh!

tiborvass commented Sep 23, 2014

Uh oh!

jessfraz commented Sep 23, 2014

Uh oh!

jessfraz commented Sep 23, 2014

Uh oh!

SvenDowideit commented Sep 23, 2014

Uh oh!

jessfraz commented Sep 23, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tiborvass commented Sep 24, 2014

Uh oh!

crosbymichael commented Sep 24, 2014

Uh oh!

LK4D4 commented Sep 24, 2014

Uh oh!

tiborvass commented Sep 24, 2014

Uh oh!

jessfraz commented Sep 24, 2014

Uh oh!

jessfraz commented Sep 24, 2014

Uh oh!

thaJeztah commented Sep 24, 2014

Uh oh!

jessfraz commented Sep 24, 2014

Uh oh!

thaJeztah commented Sep 24, 2014

Uh oh!

vieux commented Sep 25, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SvenDowideit commented Sep 25, 2014

Uh oh!

jamtur01 commented Sep 25, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

will pull only the image named debian:testing and any intermediate layers

it is based on. (Typically the empty scratch image, a MAINTAINER layer,

will pull the image named debian:testing, debian:jessie

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fredlf commented Sep 25, 2014

Uh oh!

tiborvass commented Sep 25, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

it is based on. (Typically the empty `scratch` image, a MAINTAINER layer,