Added OutboundNAT policy support for Windows#2070
Merged
fcrisciani merged 1 commit intomoby:masterfrom Feb 7, 2018
Merged
Conversation
|
Please sign your commits following these rules: $ git clone -b "master" git@github.com:nwoodmsft/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
…options Signed-off-by: Nick Wood <nwood@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #2070 +/- ##
=========================================
Coverage ? 40.51%
=========================================
Files ? 138
Lines ? 22172
Branches ? 0
=========================================
Hits ? 8983
Misses ? 11872
Partials ? 1317Continue to review full report at Codecov.
|
Contributor
|
LGTM |
Contributor
|
ping @fcrisciani @mavenugo ; Flavio, Madhu, can you review please? Note that this change affects windows only. |
ddebroy
approved these changes
Feb 7, 2018
Contributor
ddebroy
left a comment
There was a problem hiding this comment.
LGTM overall with one suggestion.
| } | ||
| config.VSID = uint(vsid) | ||
| case EnableOutboundNat: | ||
| if system.GetOSVersion().Build <= 16236 { |
Contributor
There was a problem hiding this comment.
Can the build number 16236 be defined as a global constant? It seems to be used at a couple of places.
|
Comment can be addressed in a separate Pr, merging this one |
4 tasks
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 8, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070), and In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparissons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 8, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070), and In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparissons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 8, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 12, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 25, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 25, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Jun 25, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Jun 25, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Nov 25, 2019
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/libnetwork
that referenced
this pull request
Apr 7, 2021
This replaces the hard-coded build numbers with constants that are now defined in hcsshim. Note that build 16236 is not defined in the package, and may be referring to RS2 (which was a client-only release). Checks for this version were added in commits; a9db5c5 (moby#1900), and 6681c02 (moby#2070) In a9db5c5, it is described that the intent was to allow these options only in Windows RS3 so I changed the comparisons to match RS3 (and up), or disable the option on anything older than RS3. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for OutboundNAT policy to the Windows driver passed via a generic option.