Skip to content

Tasks connected to a swarm network will have 1 endpoint on windows RS3.#1900

Merged
fcrisciani merged 2 commits intomoby:masterfrom
pradipd:overlay_one_endpoint
Aug 28, 2017
Merged

Tasks connected to a swarm network will have 1 endpoint on windows RS3.#1900
fcrisciani merged 2 commits intomoby:masterfrom
pradipd:overlay_one_endpoint

Conversation

@pradipd
Copy link
Copy Markdown
Contributor

@pradipd pradipd commented Aug 10, 2017

No description provided.

pradipd added 2 commits August 9, 2017 14:13
@pradipd
For RS3, tasks connected to a swarm network will have 1 endpoint .
a9db5c5 
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
@pradipd
gofmt and lint changes.
bf1804d 
Signed-off-by: Pradip Dhara <pradipd@microsoft.com>
@pradipd
Copy link
Copy Markdown
Contributor Author

pradipd commented Aug 10, 2017

@msabansal please review

pradipd
pradipd commented Aug 10, 2017
View reviewed changes
drivers/windows/overlay/ov_endpoint_windows.go
@@ -15,12 +19,14 @@ type endpointTable map[string]*endpoint
const overlayEndpointPrefix = "overlay/endpoint"

type endpoint struct {
Copy link
Copy Markdown
Contributor Author

@pradipd pradipd Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should look at converging type endpoint struct and type hnsEnpoint struct in windows pkg so they can be shared by all windows and overlay drivers. But, I think that is outside the scope of this PR.

pradipd
pradipd commented Aug 11, 2017
View reviewed changes
drivers/windows/overlay/ov_endpoint_windows.go

hnsEndpoint.Policies = append(hnsEndpoint.Policies, paPolicy)

if system.GetOSVersion().Build > 16236 {
Copy link
Copy Markdown
Contributor Author

@pradipd pradipd Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will move this check into hns.

Copy link
Copy Markdown
Contributor

@msabansal msabansal Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msabansal
Copy link
Copy Markdown
Contributor

msabansal commented Aug 14, 2017

LGTM

@pradipd
Copy link
Copy Markdown
Contributor Author

pradipd commented Aug 15, 2017

@mavenugo @fcrisciani Can we merge this pull request?

@pradipd
Copy link
Copy Markdown
Contributor Author

pradipd commented Aug 15, 2017

@mavenugo @fcrisciani Or review it and give feedback so that we can merge it.

@fcrisciani
Copy link
Copy Markdown

fcrisciani commented Aug 23, 2017

LGTM, @pradipd can you confirm that is ready to be merged?

@pradipd
Copy link
Copy Markdown
Contributor Author

pradipd commented Aug 28, 2017

@fcrisciani it is ready to be merged.

@fcrisciani fcrisciani merged commit c555dfd into moby:master Aug 28, 2017
@pradipd pradipd deleted the overlay_one_endpoint branch September 19, 2017 05:02
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 8, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
4b5ac00 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070), and

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparissons to match RS3 (and up), or
disable the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Apr 8, 2019
Closed
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 8, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
0ad66db 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070), and

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparissons to match RS3 (and up), or
disable the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 8, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
1f34543 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 12, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
e8cb470 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 25, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
eb73a24 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 25, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
b87dbc4 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Jun 25, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
18db6ab 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Jun 25, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
315d4ab 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Nov 25, 2019
@thaJeztah
Use hcsshim constants for Windows build numbers
386403d 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/libnetwork that referenced this pull request Apr 7, 2021
@thaJeztah
Use hcsshim constants for Windows build numbers
b000a74 
This replaces the hard-coded build numbers with constants that
are now defined in hcsshim.

Note that build 16236 is not defined in the package, and may
be referring to RS2 (which was a client-only release).

Checks for this version were added in commits;

a9db5c5 (moby#1900), and
6681c02 (moby#2070)

In a9db5c5, it is described
that the intent was to allow these options only in Windows RS3
so I changed the comparisons to match RS3 (and up), or disable
the option on anything older than RS3.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msabansal msabansal msabansal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pradipd @msabansal @fcrisciani