ENH: collapse Jupyter Notebook html representations by vagechirkov · Pull Request #9255 · mne-tools/mne-python

vagechirkov · 2021-04-06T01:29:59Z

Reference issues: #9249 #9177

Collapsed sections:

Details

Expand sections:

Details

drammock · 2021-04-06T21:48:07Z

For the last day or so, Circle CI was not properly rendering changed tutorials. It should be fixed now; can you merge current main into this PR (or rebase against main) to see if it actually executes the "reports" tutorial, so we can see this in-situ?

…ls#9248) * expose cbar label param; update test * update changelog * Update mne/viz/_3d.py Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * fix error message grammar * Update mne/viz/tests/test_3d.py Co-authored-by: Eric Larson <larson.eric.d@gmail.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>

* fix comparing array to string * update changelog * fix: prev changelog entry in wrong place

* remove cruft * fix dataframe x-scrolling for latest docutils [skip azp][skip github] * touch tutorial [skip github][skip azp] * fix acronyms in BibTeX * remove month fields * remove keyword fields * whitespace * cruft * remove language fields * touch tutorial again (why?) * FIX: Cats Co-authored-by: Eric Larson <larson.eric.d@gmail.com>

* MAINT: Encapsulate and separate notebook tests * FIX: Fixture * MAINT: ipytest requirement * ENH: Add * WIP: Closer-ish * FIX * FIX: Scope? * Fix conftest * TST: Skip Windows Co-authored-by: Guillaume Favelier <guillaume.favelier@gmail.com>

* BUG: Fix coordinate frame * FIX: Better test * FIX: Test

* implement to_df method; missing selection attr * add to_data_frame method * Apply suggestions from code review Co-authored-by: Britta Westner <britta.wstnr@gmail.com> * cosmetics * add test_to_data_frame * fix tests _index and _time_format * fix codespell * fix codespell (I now learned to run flake locally) * add selection, drop_log to EpochsTFR * forward selection and drop_log to EpochsTFR * assign selection and drop_log also in else case * consistency checks * add tests for selection, drop_log, rw epochstfr * doc: add EpochsTFR to params of read_ write_tfrs * add doc string for test_init_EpochsTFR * fix doc str test * move to_data_frame to _BaseTFR for inheritance * extend tests * simplify Co-authored-by: Daniel McCloy <dan@mccloy.info> * upgrade coding style Co-authored-by: Daniel McCloy <dan@mccloy.info> * shorten doc string Co-authored-by: Daniel McCloy <dan@mccloy.info> * shorten doc string Co-authored-by: Daniel McCloy <dan@mccloy.info> * Apply suggestions from code review Co-authored-by: eioe <klotzsche@cbs.mpg.de> Co-authored-by: Britta Westner <britta.wstnr@gmail.com> Co-authored-by: Daniel McCloy <dan@mccloy.info>

vagechirkov · 2021-04-06T22:50:22Z

merge current main into this PR

I am using this command:

>> git pull --rebase

Is it the correct way to rebase?

vagechirkov · 2021-04-06T23:01:16Z

I have also added for Circle CI rendering the tutorial plot_20_events_from_raw.py from issue #9249.

drammock · 2021-04-07T01:36:22Z

merge current main into this PR

I am using this command:
>> git pull --rebase
Is it the correct way to rebase?

There are a few different ways to do it. Assuming you're on the collapsible-repr-html branch already, you can do

git fetch upstream
git rebase upstream/main

or you can do

git pull --rebase upstream/main

For the purposes of MNE-Python development, this is also fine: git pull upstream/main or git fetch upstream; git merge upstream/main. The reason it doesn't matter whether you rebase or merge is that when we merge PRs we squash all the PR commits into one commit, so the diff between main and this branch will end up looking the same either way.

vagechirkov · 2021-04-07T09:23:38Z

merge current main into this PR

I am using this command:
>> git pull --rebase
Is it the correct way to rebase?
There are a few different ways to do it. Assuming you're on the collapsible-repr-html branch already, you can do
git fetch upstream
git rebase upstream/main
or you can do
git pull --rebase upstream/main
For the purposes of MNE-Python development, this is also fine: git pull upstream/main or git fetch upstream; git merge upstream/main. The reason it doesn't matter whether you rebase or merge is that when we merge PRs we squash all the PR commits into one commit, so the diff between main and this branch will end up looking the same either way.

Thank you very much for the explanation!

hoechenberger · 2021-04-08T07:09:37Z

Sorry for not getting back to you, @vagechirkov. I will have time to take a closer look at this hopefully tonight!

vagechirkov · 2021-04-08T14:17:07Z

For me personally, it seems convenient to have HTML representations with an option to collapse sections. But this is probably more related to issue #9177 than #9249.

vagechirkov added 2 commits April 6, 2021 03:19

collapsible additional info

ed47b4f

make plot_report.py visible for checks

2b77cb8

drammock and others added 7 commits April 7, 2021 00:46

fix: error when passing axes to plot_compare_evokeds (mne-tools#9252)

e17a82d

* fix comparing array to string * update changelog * fix: prev changelog entry in wrong place

fix for MPL 3.4.x (mne-tools#9253)

329eafe

BUG: Fix coordinate frame (mne-tools#9251)

7070a60

* BUG: Fix coordinate frame * FIX: Better test * FIX: Test

make plot_20_events_from_raw.py visible for checks

76785fb

vagechirkov added 2 commits April 7, 2021 16:40

Add collapsible sections for Info and BaseRaw

c75d225

fix flack8 style

1cb735c

vagechirkov marked this pull request as ready for review April 7, 2021 20:15

vagechirkov changed the title ~~WIP ENH: collapse too long Jupyter Notebook representations~~ ENH: collapse Jupyter Notebook html representations Apr 7, 2021

add colspan for sections' labels

b846075

vagechirkov and others added 3 commits April 9, 2021 14:53

fix pydocstyle

da53458

Merge branch 'main' into collapsible-repr-html

b639377

fix docs

3a19872

larsoner added this to the 1.6 milestone Oct 1, 2023

larsoner assigned drammock Oct 1, 2023

drammock mentioned this pull request Oct 3, 2023

Collapsible html repr for raw/info #12064

Merged

larsoner closed this in #12064 Oct 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ENH: collapse Jupyter Notebook html representations#9255

ENH: collapse Jupyter Notebook html representations#9255
vagechirkov wants to merge 16 commits intomne-tools:mainfrom
vagechirkov:collapsible-repr-html

vagechirkov commented Apr 6, 2021 •

edited

Loading

Uh oh!

drammock commented Apr 6, 2021

Uh oh!

vagechirkov commented Apr 6, 2021

Uh oh!

vagechirkov commented Apr 6, 2021

Uh oh!

drammock commented Apr 7, 2021

Uh oh!

vagechirkov commented Apr 7, 2021

Uh oh!

hoechenberger commented Apr 8, 2021

Uh oh!

vagechirkov commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

vagechirkov commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

drammock commented Apr 6, 2021

Uh oh!

vagechirkov commented Apr 6, 2021

Uh oh!

vagechirkov commented Apr 6, 2021

Uh oh!

drammock commented Apr 7, 2021

Uh oh!

vagechirkov commented Apr 7, 2021

Uh oh!

hoechenberger commented Apr 8, 2021

Uh oh!

vagechirkov commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vagechirkov commented Apr 6, 2021 •

edited

Loading