Fix html table scrolling again#9254
Merged
larsoner merged 11 commits intomne-tools:mainfrom Apr 6, 2021
Merged
Conversation
Member
|
can you share a rendered page with the fix? thx
… |
Member
Author
|
@larsoner it seems like CircleCI is no longer auto-executing the tutorials that are edited in a PR? The artifact for this PR (https://26834-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/epochs/plot_40_autogenerate_metadata.html) doesn't have any cell output. |
Member
|
Should be fixed now, I introduced the regression when refactoring CircleCI yesterday |
Member
Author
|
Thanks @larsoner! Looks like the horizontal scrolling is working again. Ready for review/merge on my end. |
larsoner
approved these changes
Apr 6, 2021
Member
|
Thanks @drammock |
vagechirkov
pushed a commit
to vagechirkov/mne-python
that referenced
this pull request
Apr 6, 2021
* remove cruft * fix dataframe x-scrolling for latest docutils [skip azp][skip github] * touch tutorial [skip github][skip azp] * fix acronyms in BibTeX * remove month fields * remove keyword fields * whitespace * cruft * remove language fields * touch tutorial again (why?) * FIX: Cats Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior fix in #8977 seems to have been short-lived. Locally for me with latest docutils (0.17) this now works again (pretty-printing dataframes in our tutorials once again creates a horizontal scrollbar). Let's see if CircleCI behaves the same way.
Also removes from website template cruft that is no longer needed due to theme updates.