expose colorbar label parameter in plot_sensors_connectivity#9248
expose colorbar label parameter in plot_sensors_connectivity#9248drammock merged 5 commits intomne-tools:mainfrom
Conversation
We can hopefully trust our abstraction of the backends to take care of this. But in theory you should be able to get to it by going through the Mayavi traits-based internals. Generally these reflect the VTK classes but are Python-ized (snake instead of camel, remove vtk prefix, and using settrs and getters instead of functions), but I think it's okay not to do this here. |
larsoner
left a comment
There was a problem hiding this comment.
Otherwise LGTM, maybe a quick latest.inc update would be good?
In theory maybe, but not in practice. I tried for about 15 minutes to find the object-based accessor for the scalar bar. Eventually resorting to the mayavi scene recording feature and click-dragging the bar yielded something like |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
all green, in it goes! |
…ls#9248) * expose cbar label param; update test * update changelog * Update mne/viz/_3d.py Co-authored-by: Eric Larson <larson.eric.d@gmail.com> * fix error message grammar * Update mne/viz/tests/test_3d.py Co-authored-by: Eric Larson <larson.eric.d@gmail.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
closes #9228
Note that I couldn't figure out how to test this when backend is Mayavi.