fix mne.viz.plot_topomap with some missing grad in a pair#8817
Merged
larsoner merged 2 commits intomne-tools:mainfrom Feb 1, 2021
Merged
fix mne.viz.plot_topomap with some missing grad in a pair#8817larsoner merged 2 commits intomne-tools:mainfrom
larsoner merged 2 commits intomne-tools:mainfrom
Conversation
larsoner
reviewed
Feb 1, 2021
|
|
||
| def test_plot_topomap_bads_grad(): | ||
| """Test plotting topomap with bad gradiometer channels (gh-8802).""" | ||
| import matplotlib.pyplot as plt |
Member
There was a problem hiding this comment.
No need to nest these imports anymore due to pytest infrastructure, eventually we can move these to the top. But it can be another PR since this whole file suffers from our old conventions.
| info = pick_info(info, picks) | ||
| assert len(info['chs']) == 203 | ||
| plot_topomap(data, info, res=8) | ||
| plt.close('all') |
Member
There was a problem hiding this comment.
Same here, no need to plt.close('all') at the end, it happens automatically via pytest now
Member
|
Thanks @agramfort |
larsoner
added a commit
to adam2392/mne-python
that referenced
this pull request
Feb 1, 2021
* upstream/main: MRG, ENH: Add warning about bad whitener conditioning (mne-tools#8805) MRG, MAINT: Deprecated param and pytest-qt (mne-tools#8808) fix mne.viz.plot_topomap with some missing grad in a pair (mne-tools#8817) [MRG] Coregistration-GUI: use *.mff as digitization source (mne-tools#8790) FIX: Path [MRG] ENH EGI MFF reader: populate info['dig'] (mne-tools#8789) MRG: Improve Brain UX (mne-tools#8792) FIX missing Axes3D import in viz._3d._plot_mpl_stc (mne-tools#8811) Better error message if configured download folder doesn't exist (mne-tools#8809) MRG, ENH: Add support for other formats to browse_raw (mne-tools#8807) MRG, BUG: Allow depth > 1 (mne-tools#8804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8802