MRG, MAINT: Deprecated param and pytest-qt#8808
Merged
GuillaumeFavelier merged 13 commits intomne-tools:mainfrom Feb 1, 2021
Merged
MRG, MAINT: Deprecated param and pytest-qt#8808GuillaumeFavelier merged 13 commits intomne-tools:mainfrom
GuillaumeFavelier merged 13 commits intomne-tools:mainfrom
Conversation
Contributor
|
Since I'm also pleasantly surprised that |
Member
Author
|
Well this appears not to work. 😭 I'll remove all the |
Contributor
|
Thank you for trying. I will exclude it from the possibilities. It's still not clear to me what instruction causes the crash though. If it's only I will investigate. |
86 tasks
Member
Author
|
Sometimes it's in paintEvent, too |
Member
Author
|
Feel free to merge this one if you're happy with it in the meantime though |
Contributor
|
Thanks @larsoner |
larsoner
added a commit
to adam2392/mne-python
that referenced
this pull request
Feb 1, 2021
* upstream/main: MRG, ENH: Add warning about bad whitener conditioning (mne-tools#8805) MRG, MAINT: Deprecated param and pytest-qt (mne-tools#8808) fix mne.viz.plot_topomap with some missing grad in a pair (mne-tools#8817) [MRG] Coregistration-GUI: use *.mff as digitization source (mne-tools#8790) FIX: Path [MRG] ENH EGI MFF reader: populate info['dig'] (mne-tools#8789) MRG: Improve Brain UX (mne-tools#8792) FIX missing Axes3D import in viz._3d._plot_mpl_stc (mne-tools#8811) Better error message if configured download folder doesn't exist (mne-tools#8809) MRG, ENH: Add support for other formats to browse_raw (mne-tools#8807) MRG, BUG: Allow depth > 1 (mne-tools#8804)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About a quarter of our macOS and Linux conda runs are dying because of
setIconcalls in PyVista. I even hit it locally once in several tests. This PR tries to avoid this by usingqtbot.wait_exposedin case it's some multi-window problem.It also changes
fig.gca(projection='3d')calls that are deprecated in latest matplotlibmasterto more modern calls that explicitly create axes.Hopefully all comes back green and I can try restarting macOS and Linux a few times to see if it's more reliable.