Conversation
|
Okay, I'm on it |
|
This is my report for
I think the |
|
I identified the issue with
I would recommend to proceed with caution here. PyVista made the difference between 'close' and 'clean'. I suggest that we stick to it until we can have a proper discussion or plan in pyvista/pyvista#959 The way I see it, Brain -> BackgroundPlotter -> BasePlotter (-> : depends on) so the sequence should be (in this order): Brain.close(), BackgroundPlotter.close(), BasePlotter.close(), Brain.clean(), BackgroundPlotter.clean(), BasePlotter.clean() |
|
I identified the issue with the segfault on 2). On our code, the patch to remove lights should be removed and EDIT: I can work something out, it's just some cleaning to do |
Do you mean |
Yes. I used 'clean' just to give the idea |
|
I reverted the I'll go ahead and merge this since it has a fix for latest |
* upstream/master: Fix separate canvas (mne-tools#8408) FIX: focalpoint (mne-tools#8405) WIP: Refs (mne-tools#8406) tiny cosmetic improvements to BEM code (mne-tools#8404) MRG, ENH: Fix memory on CircleCI (mne-tools#8379) MRG: Update backend parameter in stc.plot() (mne-tools#8395)
@GuillaumeFavelier on pyvista/pyvista#958 and pyvista/pyvistaqt#66 using
pytest mne/viz/_brainI get:Can you look and push commits to fix?