Conversation
mne/viz/_3d.py
Outdated
|
|
||
| renderer.set_camera(azimuth=90, elevation=90, | ||
| distance=0.6, focalpoint=(0., 0., 0.)) | ||
| distance=0.6) |
There was a problem hiding this comment.
The real question is what should the default actually be? I think (0., 0., 0.) is a reasonable choice for us. In all 3D plotting cases I can think of, (0., 0., 0.) is meaningful (center of some coordinate frame) so I would leave this as the default, and then just set it explicitly to focalpoint=None or focalpoint=(...) in places where we want it to be something different.
There was a problem hiding this comment.
We want a fixed value for plot_alignment? The default uses the bounds for now.
There was a problem hiding this comment.
Yes for plot_alignment in particular it seems reasonable to use (0., 0., 0.) because it's the alignment in the given coord_frame
|
The default values for
|
|
The artifacts for the fixed example are available here: https://22876-1301584-gh.circle-artifacts.com/0/dev/auto_examples/visualization/plot_3d_to_2d.html#sphx-glr-auto-examples-visualization-plot-3d-to-2d-py Also, |
|
Thanks @GuillaumeFavelier |
* upstream/master: Fix separate canvas (mne-tools#8408) FIX: focalpoint (mne-tools#8405) WIP: Refs (mne-tools#8406) tiny cosmetic improvements to BEM code (mne-tools#8404) MRG, ENH: Fix memory on CircleCI (mne-tools#8379) MRG: Update backend parameter in stc.plot() (mne-tools#8395)
This PR follows #8379 (comment) and fixes at least
plot_3d_to_2d.py