MRG, MAINT: Work around PyVista rendering bug#7416
Merged
GuillaumeFavelier merged 1 commit intomne-tools:masterfrom Mar 10, 2020
Merged
MRG, MAINT: Work around PyVista rendering bug#7416GuillaumeFavelier merged 1 commit intomne-tools:masterfrom
GuillaumeFavelier merged 1 commit intomne-tools:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7416 +/- ##
==========================================
- Coverage 85.61% 85.61% -0.01%
==========================================
Files 454 454
Lines 82221 82227 +6
Branches 13002 13003 +1
==========================================
+ Hits 70392 70397 +5
Misses 9162 9162
- Partials 2667 2668 +1 |
Member
Author
|
Looks fixed. Feel free to review/merge if you're happy with this temporary workaround @GuillaumeFavelier |
Contributor
|
Thank you @larsoner |
GuillaumeFavelier
added a commit
to GuillaumeFavelier/mne-python
that referenced
this pull request
Mar 17, 2020
larsoner
added a commit
that referenced
this pull request
Mar 19, 2020
* Prepare for next version of pyvista * Use latest version 0.24 of pyvista * Revert #7416 * TST: Trigger CIs * TST: Circle Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for PyVista scraping. @GuillaumeFavelier feel free to look and decide if it needs a backport (not sure what the PyVista scraper duplication status is). All I really did was add the
if plotter in seen_plotters:check and accumulation and it appears to fix things.Alternative to #7398
Closes #7398
Closes #7228