Skip to content

MNT: Revert to mayavi as 3d backend for building the documentation#7398

Closed
GuillaumeFavelier wants to merge 5 commits intomne-tools:masterfrom
GuillaumeFavelier:circle_mayavi
Closed

MNT: Revert to mayavi as 3d backend for building the documentation#7398
GuillaumeFavelier wants to merge 5 commits intomne-tools:masterfrom
GuillaumeFavelier:circle_mayavi

Conversation

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 6, 2020

This PR follows #7228 (comment) and reverts Circle's config to use mayavi to build the documentation until #7228 is fixed at least.

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 6, 2020
@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Mar 6, 2020 •
edited
Loading

time_viewer=True needs to be reverted in plot_visualize_stc.py

...
generating gallery for auto_tutorials/source-modeling... [ 83%] plot_object_source_estimate.py
generating gallery for auto_tutorials/source-modeling... [ 91%] plot_source_alignment.py
generating gallery for auto_tutorials/source-modeling... [100%] plot_visualize_stc.py
Makefile:44: recipe for target 'html_dev' failed
make: *** [html_dev] Terminated

Too long with no output (exceeded 10m0s): context deadline exceeded

Reference: https://circleci.com/gh/mne-tools/mne-python/18369?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@76d8495). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7398   +/-   ##
=========================================
  Coverage          ?   90.01%           
=========================================
  Files             ?      453           
  Lines             ?    82225           
  Branches          ?    13011           
=========================================
  Hits              ?    74015           
  Misses            ?     5384           
  Partials          ?     2826

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Mar 6, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Mar 6, 2020

To get it back, it mostly depends on:

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Mar 6, 2020 via email

@GuillaumeFavelier
Copy link
Copy Markdown
Contributor Author

GuillaumeFavelier commented Mar 6, 2020 •
edited
Loading

But bringing time_viewer='auto' is not compatible with letting mayavi as default 3d backend for documentation because of #7398 (comment)

@larsoner larsoner mentioned this pull request Mar 10, 2020
Merged
@larsoner larsoner added this to the 0.20 milestone Mar 10, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the circle_mayavi branch June 11, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

VIZ

Projects

None yet

Milestone

0.20

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeFavelier @agramfort @larsoner