MRG, FIX: Allow unknown when setting montage#7122
Merged
agramfort merged 7 commits intomne-tools:maint/0.19from Dec 5, 2019
Merged
MRG, FIX: Allow unknown when setting montage#7122agramfort merged 7 commits intomne-tools:maint/0.19from
agramfort merged 7 commits intomne-tools:maint/0.19from
Conversation
Member
|
the question is should we allow this @larsoner ? |
Member
Author
The question is, do we want people to be able to set these if they don't have fiducials? In |
* testing reading old data * failed as expected, fixing * added to changelog * added my name * deleted reference to private function in docs * more latest changes, probably wrong but I don't know how to reference a private function * small doc changes
Codecov Report
@@ Coverage Diff @@
## maint/0.19 #7122 +/- ##
==============================================
- Coverage 89.67% 89.66% -0.01%
==============================================
Files 422 422
Lines 76762 76777 +15
Branches 12556 12560 +4
==============================================
+ Hits 68834 68841 +7
- Misses 5115 5122 +7
- Partials 2813 2814 +1 |
agramfort
approved these changes
Dec 5, 2019
Member
|
thx @larsoner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of #7118 which was closed due to a bad push.