MRG, FIX: Allow unknown when setting montage#7118
Merged
larsoner merged 4 commits intomne-tools:maint/0.19from Dec 5, 2019
Merged
MRG, FIX: Allow unknown when setting montage#7118larsoner merged 4 commits intomne-tools:maint/0.19from
larsoner merged 4 commits intomne-tools:maint/0.19from
Conversation
This was referenced Dec 4, 2019
Codecov Report
@@ Coverage Diff @@
## maint/0.19 #7118 +/- ##
==============================================
- Coverage 89.66% 88.26% -1.41%
==============================================
Files 422 422
Lines 76762 76767 +5
Branches 12556 12560 +4
==============================================
- Hits 68832 67761 -1071
- Misses 5117 6191 +1074
- Partials 2813 2815 +2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7114.
For backward compat, we should allow setting montages with
coord_frame='unknown'if not all fids are present. Now we do so with a warning.