[BUG] testing reading old data#7036
Merged
agramfort merged 7 commits intomne-tools:masterfrom Nov 9, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7036 +/- ##
==========================================
- Coverage 89.7% 89.64% -0.07%
==========================================
Files 438 438
Lines 77467 77472 +5
Branches 12580 12580
==========================================
- Hits 69491 69447 -44
- Misses 5164 5211 +47
- Partials 2812 2814 +2 |
drammock
reviewed
Nov 8, 2019
Member
drammock
left a comment
There was a problem hiding this comment.
How to format this: Enclose it in double backticks to render it as code (won't generate a crossref link). But ask yourself why an end user needs to know exactly which internal private function was changed here. Maybe it's enough to just say "behavior X changed to support situation Y".
Member
|
thx @alexrockhill |
This was referenced Dec 5, 2019
larsoner
pushed a commit
to larsoner/mne-python
that referenced
this pull request
Dec 5, 2019
* testing reading old data * failed as expected, fixing * added to changelog * added my name * deleted reference to private function in docs * more latest changes, probably wrong but I don't know how to reference a private function * small doc changes
agramfort
pushed a commit
that referenced
this pull request
Dec 5, 2019
* FIX: Allow unknown * DOC: whats_new * FIX: sklearn import * FIX: More * FIX: Fix for latest NumPy * [BUG] testing reading old data (#7036) * testing reading old data * failed as expected, fixing * added to changelog * added my name * deleted reference to private function in docs * more latest changes, probably wrong but I don't know how to reference a private function * small doc changes * FIX: Rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue related to mne-tools/mne-bids#280.
Windows throws an error when datetime.fromtimestamp is less than 0. This is the case for dates before 1970 Jan 1. I suspect that the way mne.io.meas_info._stamp_to_dt uses datetime.fromtimestamp will fail on a Windows OS. I am not by a windows machine and so cannot confirm but if the tests for windows fail, then I will fix it by using datetime.fromtimestamp(0) and then adding the argument that was being passed to fromtimestamp to timedelta. Basically, instead of reading from a timestamp, the number that was to be read from a timestamp will be used to move the time back stamp number of seconds.