Skip to content

FIX: plot DigMontage#6744

Merged
agramfort merged 2 commits intomne-tools:masterfrom
massich:digmontage_plot
Sep 12, 2019
Merged

FIX: plot DigMontage#6744
agramfort merged 2 commits intomne-tools:masterfrom
massich:digmontage_plot

Conversation

@massich
Copy link
Copy Markdown
Contributor

@massich massich commented Sep 9, 2019 •
edited
Loading

This change avoids DigMontage.plot() to not break.

But I'm not sure if its ok that ploting Montage and DigMontage lets to different plots. Maybe this should be taken care in #6649

image

to reproduce the figure:

import numpy as np
import os.path as op
from mne.datasets import testing

from mne.channels import make_dig_montage, read_montage, read_dig_captrack
data_path = testing.data_path(download=False)

foo = make_dig_montage(ch_pos=dict(zip(list('abc'), np.eye(3))))
foo.plot()

montage = read_montage('GSN-HydroCel-32')
montage.plot()

dm = read_dig_captrack(fname=op.join(data_path, 'montage', 'captrak_coords.bvct'))
dm.plot()

@agramfort
Copy link
Copy Markdown
Member

agramfort commented Sep 9, 2019

besides CIs issues LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2019 •
edited
Loading

Codecov Report

Merging #6744 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6744      +/-   ##
==========================================
- Coverage   89.59%   89.56%   -0.03%     
==========================================
  Files         419      419              
  Lines       75839    75846       +7     
  Branches    12423    12424       +1     
==========================================
- Hits        67946    67930      -16     
- Misses       5098     5118      +20     
- Partials     2795     2798       +3

This was referenced Sep 11, 2019
Closed
Closed
@agramfort agramfort merged commit 8cc11b5 into mne-tools:master Sep 12, 2019
@massich massich deleted the digmontage_plot branch September 13, 2019 13:52
alexrockhill pushed a commit to alexrockhill/mne-python that referenced this pull request Oct 1, 2019
@massich
FIX: plot DigMontage (mne-tools#6744)
9648a4c 
* FIX: plot DigMontage

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@massich @agramfort