[RFC] Are we aiming to be able to write plot_montage like this?#6649
Closed
massich wants to merge 1 commit intomne-tools:masterfrom
Closed
[RFC] Are we aiming to be able to write plot_montage like this?#6649massich wants to merge 1 commit intomne-tools:masterfrom
massich wants to merge 1 commit intomne-tools:masterfrom
Conversation
agramfort
reviewed
Aug 9, 2019
| montage.ch_names = [montage.ch_names[i] for i in idx] | ||
| ch_names = montage.ch_names | ||
| montage.pos = montage.pos[idx, :] | ||
| montage.selection = np.arange(n_chans - n_dupes) |
Member
There was a problem hiding this comment.
this was here for a reason. cc @larsoner
+1 for unify attributes of montage and digmontage. point_names is not great. I also think that only channels have names.
Member
Merged
Member
|
this code will die when we remove Montage class after the next release. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just me thinking outloud.
While working in #6639 I find myself touching things that make
montages look more similar. And I think we should be able to get
to something similar to what this PR shows.
This requires:
cross-ref: #6461
cc: @agramfort