MAINT: Bump to latest pydata-sphinx-theme#12228
Conversation
|
@drammock at least from a 10 second inspection it doesn't look terrible |
|
Thanks for tackling, I'll look on the weekend.
…-------- Original Message --------
On 4/12/24 11:07, Eric Larson wrote:
***@***.***(https://github.com/drammock) at least from a 10 second inspection it doesn't look terrible
https://output.circle-artifacts.com/output/job/1d6a426a-14dd-4b9d-8013-72cab5090ab3/artifacts/0/html/index.html
—
Reply to this email directly, [view it on GitHub](#12228 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAN2AU7B4UHV4WZOCMMMHPLY5ABF7AVCNFSM6AAAAAA7UU6ZVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJSGA2TEMBZGI).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@larsoner I pushed a few commits. Based on local builds I'm happy with how this looks now (I removed several of our overrides to hew closer to the stock theme; we may want to deviate again eventually but if so we should do it intentionally, not by keeping around old overrides based on an old theme style). |
| .. admonition:: Git GUI alternative | ||
| :class: sidebar note |
There was a problem hiding this comment.
all changes in this file are just things I happened to notice when reviewing the theme update.
| .. contents:: Page contents | ||
| :local: |
There was a problem hiding this comment.
in-page TOC is built into the theme in the right sidebar, so this is redundant
| --mne-color-primary: #007bff; | ||
| --mne-color-primary-highlight: #0063cc; |
There was a problem hiding this comment.
these blues don't look good against the new theme. If we really want blue as primary, we could consider swapping the theme's info (blue) and primary (teal) colors, though there's an a11y question about color difference between link and hover, we'd have to make sure info is still different enough from hover color to satisfy WCAG
| /* prev/next links */ | ||
| .prev-next-area a p.prev-next-title { | ||
| color: var(--pst-color-link); | ||
| } |
| /* sidebar nav */ | ||
| nav.bd-links .active > a, | ||
| nav.bd-links .active:hover > a, | ||
| .toc-entry a.nav-link.active, | ||
| .toc-entry a.nav-link.active:hover { | ||
| color: var(--pst-color-link); | ||
| } | ||
| /* sidebar nav hover */ | ||
| nav.bd-links li > a:hover, | ||
| .toc-entry a.nav-link:hover { | ||
| color: var(--pst-color-secondary); | ||
| } |
There was a problem hiding this comment.
upstream defaults are good enough now I think
* upstream/main: (50 commits) ENH: Improve OPM auditory dataset and example (mne-tools#12539) MAINT: Bump to latest pydata-sphinx-theme (mne-tools#12228) MRG: Simplify manual installation instructions a little by dropping explicit mention of (lib)mamba (mne-tools#12362) fix PSD weights handling when bad annotations present (mne-tools#12538) Fix phase loading (mne-tools#12537) align FFT windows to good data spans in psd_array_welch (mne-tools#12536) explicitly disallow multitaper in presence of bad annotations (mne-tools#12535) MAINT: Clean up PyVista contexts (mne-tools#12533) MAINT: Complete API change of ordered (mne-tools#12534) MAINT: Reinstall statsmodels and improve logging (mne-tools#12532) MAINT: Remove scipy.signal.morlet2 (mne-tools#12531) Update README badge links (mne-tools#12529) BUG: Fix bug with reading his_id from snirf (mne-tools#12526) [pre-commit.ci] pre-commit autoupdate (mne-tools#12524) Fix file format check in _check_eeglab_fname function (mne-tools#12523) MAINT: Reenable picard in pre testing (mne-tools#12525) MAINT: Bump to large resource class (mne-tools#12522) MAINT: Restore 2 jobs on Windows (mne-tools#12520) Add exclude_after_unique option to mne.io.read_raw_edf/read_raw_edf to search for exclude channels after making channel names unique (mne-tools#12518) Improve consistency of sensor types in code and documentation (mne-tools#12509) ...
Just to remind us to look at and adjust this @drammock