MRG: Replace check_version from _testing.py with the same function in check.py #10958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
approved these changes
Jul 26, 2022
cbrnr
approved these changes
Jul 26, 2022
Member
Author
|
This test https://github.com/mne-tools/mne-python/blob/main/.github/workflows/linux_pip.yml could use a timeout.. |
Member
|
@larsoner It appears I cannot override the auto-merge-on-tests-pass thing, so now this PR is sitting here and I cannot merge it :( |
Contributor
|
I disabled auto-merge and rebased, but it seems like all checks still need to pass. |
larsoner
added a commit
to alexrockhill/mne-python
that referenced
this pull request
Jul 27, 2022
* upstream/main: FIX: ctf data can sometimes have no date time. (mne-tools#10957) replace check_version from _testing.py with the one in check.py (mne-tools#10958) ENH: mne-tools#10542 Adds __eq__() to DigMontage class and updates tests. (mne-tools#10942) Use HiDPI icons with PyQt5/PySide2 (mne-tools#10956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10941