Skip to content

Conversation

@TzionaN
Copy link
Contributor

@TzionaN TzionaN commented Jul 21, 2022

Reference issue

Fixes #10542

Does:

  • added 'eq' to 'DigMontage'
  • added and modifies tests

@welcome
Copy link

welcome bot commented Jul 21, 2022

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TzionaN can you add a what's new entry in latest.inc file? 🙏

@TzionaN
Copy link
Contributor Author

TzionaN commented Jul 24, 2022

Hey there!
I'm really new to contributing like this, and would love some help.

I can't seem to understand the failed build doc tests here, since there was only a minor adjustment to the doc, and it seems to match the requested syntax.
It seems to be related to the Azure pipeline, which I might have some difficulty troubleshooting. I'm currently working on a mac, and if I understand correctly, this is a Windows specific pipeline?

@hoechenberger hoechenberger enabled auto-merge (squash) July 26, 2022 08:07
@hoechenberger hoechenberger merged commit a8e9495 into mne-tools:main Jul 26, 2022
@drammock
Copy link
Member

I'm really new to contributing like this, and would love some help.

Thanks for asking for help!

I can't seem to understand the failed build doc tests here, since there was only a minor adjustment to the doc, and it seems to match the requested syntax. It seems to be related to the Azure pipeline, which I might have some difficulty troubleshooting. I'm currently working on a mac, and if I understand correctly, this is a Windows specific pipeline?

Looking at the CI runs for commit ab19cca, there were two things going on:

larsoner added a commit to alexrockhill/mne-python that referenced this pull request Jul 27, 2022
* upstream/main:
  FIX: ctf data can sometimes have no date time. (mne-tools#10957)
  replace check_version from _testing.py with the one in check.py (mne-tools#10958)
  ENH:  mne-tools#10542 Adds __eq__() to DigMontage class and updates tests. (mne-tools#10942)
  Use HiDPI icons with PyQt5/PySide2 (mne-tools#10956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add __eq__(), __neq__() to DigMontage

4 participants