Skip to content

Update inverse.rst DOC#10922

Merged
larsoner merged 3 commits intomne-tools:mainfrom
mh105:mh105-patch-1
Jul 13, 2022
Merged

Update inverse.rst DOC#10922
larsoner merged 3 commits intomne-tools:mainfrom
mh105:mh105-patch-1

Conversation

@mh105
Copy link
Contributor

@mh105 mh105 commented Jul 13, 2022 •
edited
Loading

Reference issue

Example: Fixes #10919.

What does this implement/fix?

Adds a note in the whitening section of the Algorithms and other implementation details doc to clarify that the forward model gain matrix is also average referenced during whitening.

Additional information

N/A

@mh105
Update inverse.rst
baa118e 
Adds a note in the whitening section of Algorithms and other implementation details doc to clarify the forward model gain matrix is also average referenced during whitening.
@welcome
Copy link

welcome bot commented Jul 13, 2022

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@mh105 mh105 closed this Jul 13, 2022
@mh105 mh105 reopened this Jul 13, 2022
@larsoner
Copy link
Member

larsoner commented Jul 13, 2022

@mh105 can you add an entry in doc/changes/latest.inc (using :newcontrib:) mentioning this documentation improvement and add your name+url to doc/changes/names.inc?

@mh105
Copy link
Contributor Author

mh105 commented Jul 13, 2022

@mh105 can you add an entry in doc/changes/latest.inc (using :newcontrib:) mentioning this documentation improvement and add your name+url to doc/changes/names.inc?

All set. Thanks!

@drammock
Copy link
Member

drammock commented Jul 13, 2022

Something is wrong with how :math: is getting rendered, it's inserting line breaks:

https://output.circle-artifacts.com/output/job/81345625-fb01-450f-954f-0681ba7f12ed/artifacts/0/dev/overview/implementation.html?highlight=algorithms#equation-inv-tilde-x-t

(I doubt this is due to anything you did @mh105, just mentioning here because I noticed it when looking at the rendering of your .. note box)

@mh105
Copy link
Contributor Author

mh105 commented Jul 13, 2022

Something is wrong with how :math: is getting rendered, it's inserting line breaks:

Not sure what happened. Would you like me to revert the changes and see if rendering corrects itself? It looks like that problem is affecting all :math: on the page.

@drammock
Copy link
Member

drammock commented Jul 13, 2022

Would you like me to revert the changes and see if rendering corrects itself?

no need, it's happening on main as well: https://mne.tools/dev/overview/implementation.html?highlight=algorithms#the-minimum-norm-current-estimates

@larsoner larsoner merged commit 73e1d85 into mne-tools:main Jul 13, 2022
@welcome
Copy link

welcome bot commented Jul 13, 2022

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

@larsoner
Copy link
Member

larsoner commented Jul 13, 2022

Thanks @mh105 !

@mh105 mh105 deleted the mh105-patch-1 branch July 13, 2022 19:19
larsoner added a commit to alexrockhill/mne-python that referenced this pull request Jul 14, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into backend
0139ecf 
* upstream/main:
  to_data_frame API change (mne-tools#10925)
  MAINT: Fix Qt issue (mne-tools#10923)
  Update inverse.rst DOC (mne-tools#10922)
  DOC: Clean up Forward and SourceSpaces (mne-tools#10911)
  [MAINT, MRG] Move sensor cluster permutation example to correct directory (mne-tools#10917)
  [MRG] Add data loader functions for BESA files (mne-tools#10892)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A technical question on inverse operator construction and average reference

3 participants

@mh105 @larsoner @drammock