[MRG] Add data loader functions for BESA files#10892
Merged
wmvanvliet merged 15 commits intomne-tools:mainfrom Jul 9, 2022
Merged
[MRG] Add data loader functions for BESA files#10892wmvanvliet merged 15 commits intomne-tools:mainfrom
wmvanvliet merged 15 commits intomne-tools:mainfrom
Conversation
Contributor
Author
|
This is ready for review now. |
Contributor
Author
|
@massich This PR messes with your BESA |
Member
|
@wmvanvliet IIRC @massich has moved on to other projects/domains so I would proceed without a review. I think we can trust that tests were implemented well enough that we can go based on what they tell us |
drammock
approved these changes
Jul 7, 2022
Member
drammock
left a comment
There was a problem hiding this comment.
needs a changelog entry, otherwise LGTM!
Member
|
I would have just put the testing files in the mne-testing-data |
Contributor
Author
|
They are only a few kb each. |
larsoner
added a commit
to alexrockhill/mne-python
that referenced
this pull request
Jul 14, 2022
* upstream/main: to_data_frame API change (mne-tools#10925) MAINT: Fix Qt issue (mne-tools#10923) Update inverse.rst DOC (mne-tools#10922) DOC: Clean up Forward and SourceSpaces (mne-tools#10911) [MAINT, MRG] Move sensor cluster permutation example to correct directory (mne-tools#10917) [MRG] Add data loader functions for BESA files (mne-tools#10892)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing file readers for BESA .avr and .mul files, which are simple text files containing evokeds as produces by the BESA analysis software. Needs testing.
closes #9238, #10908
Todo: