Proposals version 2. Iteration 2.#2
Closed
shamil-gadelshin wants to merge 30 commits intomnaamani:integrate-content-wgfrom
Closed
Proposals version 2. Iteration 2.#2shamil-gadelshin wants to merge 30 commits intomnaamani:integrate-content-wgfrom
shamil-gadelshin wants to merge 30 commits intomnaamani:integrate-content-wgfrom
Conversation
Added: - engine module - codex module - basic mock and tests
- add ProposalOrigin to the engine - remove commented code - update mock and test
- add vote() extrinsic - add multiple comments
- add error handling for execute_proposal() - add result printing for text proposal type
- add insufficient_rights test - add tally() for vote results - remove commented code
- separate acquiring data from mutation - add several test
- move tally_results() to Proposal impl - cover tally_results() with tests
- introduce ‘VotersParameters’ trait - add ‘TotalVotersCounter’ type to proposals engine - change tests - introduce ‘ProposalStatusDecision’
- remove extrinsic calls as executable code - introduce executable code registry - apply parity scale codec as serialization lib
- introduce proposal Executed & Failed statuses - refactor update_proposal_status() - introduce error handling (DispatchResult)
- split proposals into two crates: engine and codex - move engine and codex crates to the modules/proposals folder - place main modules code in lib.rs files - fix tests and dependencies
- add events: ProposalCanceled, ProposalVetoed, ProposalStatusUpdated, Voted - add tests for events
|
Why does this PR target |
Author
|
This PR targets |
|
In that case it makes more sense to just rebase it on top of this branch, and still target Also, lets have this as a long-running feature branch, so all future work is PRs that fork off and target this branch. The name is a bit conflicting, so if you want to you can fix that. |
|
I guess we can close this. |
mnaamani
pushed a commit
that referenced
this pull request
Mar 10, 2020
mnaamani
pushed a commit
that referenced
this pull request
Apr 16, 2020
Storage changes to Acropolis release plan
mnaamani
pushed a commit
that referenced
this pull request
Apr 16, 2020
pull recent changes from upstream
mnaamani
pushed a commit
that referenced
this pull request
Apr 16, 2020
mnaamani
pushed a commit
that referenced
this pull request
May 19, 2020
Hiring module update support
mnaamani
pushed a commit
that referenced
this pull request
May 19, 2020
add template arg to mocked event
mnaamani
pushed a commit
that referenced
this pull request
Sep 21, 2020
mnaamani
pushed a commit
that referenced
this pull request
Sep 21, 2020
* ru-translation page-claims * one more * minor fixes to ru-translation * one more fix ru-translation * Update ru i18n * change rutranslation to proposal treasury * new additions to Russian translation * fix typos * fix typos * added missed strings to Ru-translation * added missed strings to Ru-translation #2 Co-authored-by: Jaco Greeff <jacogr@gmail.com>
mnaamani
pushed a commit
that referenced
this pull request
Oct 20, 2020
mnaamani
pushed a commit
that referenced
this pull request
Dec 21, 2020
CLI - entity commands permissions fixes and code cleanup
mnaamani
pushed a commit
that referenced
this pull request
Dec 30, 2020
mnaamani
pushed a commit
that referenced
this pull request
Mar 15, 2021
integration test fixes for runtime changes
mnaamani
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Add dockerfile for arm, update workflow, add matrix
mnaamani
pushed a commit
that referenced
this pull request
Aug 10, 2022
Remove unneeded memberId (asset uploads)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.