Proposal for not having Option<T::DataObjectTypeId> in the DO type#19
Merged
siman merged 1 commit intodevelopmentfrom Apr 2, 2019
unknown repository
Merged
Proposal for not having Option<T::DataObjectTypeId> in the DO type#19siman merged 1 commit intodevelopmentfrom unknown repository
siman merged 1 commit intodevelopmentfrom
unknown repository
Conversation
struct. We have no reason in the runtime to store it as part of the struct.
Member
|
I think this is very sensible, and I like how much simpler the code is. |
mnaamani
approved these changes
Apr 2, 2019
shamil-gadelshin
pushed a commit
to shamil-gadelshin/joystream-network
that referenced
this pull request
Mar 9, 2020
shamil-gadelshin
pushed a commit
to shamil-gadelshin/joystream-network
that referenced
this pull request
Mar 9, 2020
…locker Fix runtime integration blocker
mnaamani
pushed a commit
to mnaamani/joystream
that referenced
this pull request
Mar 20, 2020
Updated node template
mnaamani
pushed a commit
to mnaamani/joystream
that referenced
this pull request
Jun 19, 2020
Chrome playback issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge immediately, @mnaamani - this is for discussion (and possibly merging later on).
So this PR gets the ID out of the struct, which I think is part of what @siman wanted.
I understand the utility of adding a separate update struct, but am not happy with having two structs with essentially the same members that could get out of sync if programmers don't pay attention. So this is my proposal for finishing #7, essentially.
If there's data structures that see updates to individual fields a lot, I think the separate update struct makes sense. Here, the only member that should get toggled a lot is the
activeflag, and that should happen rarely enough (tied to storage tranches coming post-Athens).WDYT?