[Pipelines] Experiment name normalization #8758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaelgen
requested changes
Oct 22, 2025
| ) | ||
| response_body = response.json() | ||
| assert response_body["id"] == "some-run-id" | ||
| assert response_body["name"].startswith("getting-started-tutorial-iguazio") |
Member
There was a problem hiding this comment.
Add a costume experiment to the post request, that does not start with the project name, will make the test more accurate
liranbg
reviewed
Oct 22, 2025
… for the experiment" This reverts commit 3baef7c.
10 tasks
yaelgen
pushed a commit
that referenced
this pull request
Oct 23, 2025
### 📝 Description <!-- A short summary of what this PR does. --> <!-- Include any relevant context or background information. --> Follow up PR of #8758 on @yaelgen comment --- ### 🛠️ Changes Made <!-- - Key changes (e.g., added feature X, refactored Y, fixed Z) --> - Added experiment name to `test_create_pipeline` --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [ ] If I introduced a deprecation: - [ ] I followed the [Deprecation Guidelines](./DEPRECATION.md) - [ ] I updated the relevant Jira ticket for documentation --- ### 🧪 Testing <!-- - How it was tested (unit tests, manual, integration) --> <!-- - Any special cases covered. --> --- ### 🔗 References - Ticket link: https://iguazio.atlassian.net/browse/ML-11260 - Design docs links: - External links: - Initial PR - #8758 --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [ ] No <!-- If yes, describe what needs to be changed downstream: --> --- ### 🔍️ Additional Notes <!-- Anything else reviewers should know (follow-up tasks, known issues, affected areas etc.). --> <!-- ### 📸 Screenshots / Logs -->
10 tasks
liranbg
pushed a commit
that referenced
this pull request
Jan 4, 2026
### 📝 Description Deprecate the `experiment` parameter in `submit_pipeline` as part of the gradual deprecation plan. This PR emits a warning when `experiment` is explicitly passed, while keeping backward compatibility and existing behavior intact. The parameter remains functional in versions 1.11–1.12 and will be removed in 1.13. --- ### 🛠️ Changes Made - Added a `FutureWarning` when the `experiment` parameter is passed to `submit_pipeline` - Marked the `experiment` parameter as deprecated in the function docstring - No behavioral or API changes beyond the warning --- ### ✅ Checklist - [ ] I updated the documentation (if applicable) - [x] I have tested the changes in this PR - [ ] I confirmed whether my changes are covered by system tests - [ ] If yes, I ran all relevant system tests and ensured they passed before submitting this PR - [ ] I updated existing system tests and/or added new ones if needed to cover my changes - [x] If I introduced a deprecation: - [x] I followed the Deprecation Guidelines - [x] I updated the relevant Jira ticket for documentation --- ### 🧪 Testing - Manually verified that calling `submit_pipeline` with the `experiment` parameter emits a `FutureWarning` - Verified that pipeline submission behavior remains unchanged --- ### 🔗 References - Ticket link: [<ADD JIRA TICKET>](https://iguazio.atlassian.net/browse/ML-11454) - Design docs links: N/A - External links: - Previous phase (normalization): #8758 --- ### 🚨 Breaking Changes? - [ ] Yes (explain below) - [x] No ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When the experiment name of a pipeline doesn't start with the project name as a prefix
{project}-{experiment}, thenlist_pipelinesdoesn't show the workflow (also in UI). This is handled in the SDK side when doingproject.run().However a user-provided
experiment nameis accepted in:httpdb.submit_pipeline()mlrun._run_pipelinewhich is widely used in kfp testsTo keep BC, this PR moves that code logic from
project.run()to_create_pipelinewhich is used in the endpoint.Changing this from
project.run()to the API shouldn't have any effect because thenameparameter (the experiment name) is not used anywhere along the flow after being prefixed with the project name🛠️ Changes Made
project.run()_create_pipeline()✅ Checklist
🧪 Testing
Manual + added assertion in existing unit test
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes