-
Notifications
You must be signed in to change notification settings - Fork 293
[Test] Improve test_create_pipeline #8761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…the experiment name
… for the experiment" This reverts commit 3baef7c.
| params=params, | ||
| headers={"content-type": "application/yaml"}, | ||
| auth=BasicAuth(username="admin", password="mock_token"), | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this line: assert response_body["name"].startswith("getting-started-tutorial-iguazio")
Replace the hardcoded string with the project parameter
Also, I would use exact match now instead of prefix matching for more precise validation
yaelgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
📝 Description
Follow up PR of #8758 on @yaelgen comment
🛠️ Changes Made
test_create_pipeline✅ Checklist
🧪 Testing
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes