Skip to content

Conversation

@elbamit
Copy link
Contributor

@elbamit elbamit commented Oct 23, 2025

📝 Description

Follow up PR of #8758 on @yaelgen comment


🛠️ Changes Made

  • Added experiment name to test_create_pipeline

✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing


🔗 References


🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@elbamit elbamit changed the title Ml 11260 [Test] - Improve test_create_pipeline Oct 23, 2025
@elbamit elbamit marked this pull request as ready for review October 23, 2025 07:16
@elbamit elbamit requested a review from a team as a code owner October 23, 2025 07:16
@elbamit elbamit changed the title [Test] - Improve test_create_pipeline [Test] Improve test_create_pipeline Oct 23, 2025
params=params,
headers={"content-type": "application/yaml"},
auth=BasicAuth(username="admin", password="mock_token"),
)
Copy link
Member

@yaelgen yaelgen Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this line: assert response_body["name"].startswith("getting-started-tutorial-iguazio")
Replace the hardcoded string with the project parameter
Also, I would use exact match now instead of prefix matching for more precise validation

Copy link
Member

@yaelgen yaelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yaelgen yaelgen merged commit 95d8f9e into mlrun:development Oct 23, 2025
18 checks passed
@elbamit elbamit deleted the ML-11260 branch November 5, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants