Mark auto-generated i18n files as linguist-generated in .gitattributes#21326
Merged
Mark auto-generated i18n files as linguist-generated in .gitattributes#21326
linguist-generated in .gitattributes#21326Conversation
Mark the auto-generated i18n file as linguist-generated=true in .gitattributes so it is collapsed by default in GitHub PR diffs. This file is generated by mlflow/server/js/scripts/extract-i18n.js. Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add en.json to .gitattributes as linguist-generated
Mark auto-generated en.json as linguist-generated in .gitattributes
Mar 3, 2026
harupy
approved these changes
Mar 3, 2026
en.json as linguist-generated in .gitattributes
harupy
reviewed
Mar 4, 2026
.gitattributes
Outdated
Comment on lines
+6
to
+7
| # Collapse auto-generated i18n file in pull request diffs on GitHub | ||
| mlflow/server/js/src/lang/default/en.json linguist-generated=true |
Member
There was a problem hiding this comment.
#21281 is a good example. You need to scroll a few times to reach real changes. It's not a big noise, but a minor noise. Let me know if there are any concerns.
Member
There was a problem hiding this comment.
Screen.Recording.2026-03-04.at.11.31.48.mov
daniellok-db
approved these changes
Mar 4, 2026
Collaborator
|
actually all the files in mlflow/server/js/src/lang/ are generated, but |
Member
|
Update .gitattributes to use a wildcard pattern that covers all generated i18n files in mlflow/server/js/src/lang/, not just en.json. All JSON files in this directory are auto-generated. Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Contributor
Author
Updated to use |
Copilot
AI
changed the title
Mark auto-generated
Mark auto-generated i18n files as Mar 4, 2026
en.json as linguist-generated in .gitattributeslinguist-generated in .gitattributes
daniellok-db
pushed a commit
to daniellok-db/mlflow
that referenced
this pull request
Mar 5, 2026
…utes` (mlflow#21326) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
daniellok-db
pushed a commit
to daniellok-db/mlflow
that referenced
this pull request
Mar 5, 2026
…utes` (mlflow#21326) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
daniellok-db
pushed a commit
that referenced
this pull request
Mar 5, 2026
…utes` (#21326) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Relates to #issue_number
What changes are proposed in this pull request?
All i18n JSON files in
mlflow/server/js/src/lang/are auto-generated and create noise in PR diffs. Addedlinguist-generated=trueattribute in.gitattributeswith a wildcard pattern to collapse all of them by default in GitHub PR views.This covers
en.json(generated byextract-i18n.js) as well as all other language translation files (de-DE.json, es-ES.json, fr-FR.json, it-IT.json, ja-JP.json, ko-KR.json, pt-BR.json, pt-PT.json, zh-CN.json, zh-HK.json, zh-TW.json).How is this PR tested?
Configuration change only - no functional impact. Verified using
git check-attrthat the wildcard pattern correctly matches all JSON files in the lang directory.Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/tracking: Tracking Service, tracking client APIs, autologgingarea/models: MLmodel format, model serialization/deserialization, flavorsarea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflowsarea/gateway: MLflow AI Gateway client APIs, server, and third-party integrationsarea/prompts: MLflow prompt engineering features, prompt templates, and prompt managementarea/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionalityarea/projects: MLproject format, project running backendsarea/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesHow should the PR be classified in the release notes? Choose one:
rn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notesShould this PR be included in the next patch release?
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.