Clean up assessment pane: remove type dropdown and redundant toggle#21281
Closed
B-Step62 wants to merge 2 commits intomlflow:masterfrom
Closed
Clean up assessment pane: remove type dropdown and redundant toggle#21281B-Step62 wants to merge 2 commits intomlflow:masterfrom
B-Step62 wants to merge 2 commits intomlflow:masterfrom
Conversation
The close (x) button inside the assessments pane already provides the hide functionality, so the toggle button is now hidden when the pane is expanded and only shown as "Show assessments" when collapsed. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
…xpectations The assessment creation form no longer shows a redundant "Assessment Type" dropdown since the type is determined by which section (Feedback or Expectations) the form is opened from. Updated terminology throughout: - "Assessment Name" → "Name" - Placeholder: "Enter a feedback name" / "Enter an expectation name" - Removed "Assessments" title from pane header (section headers suffice) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: B-Step62 <yuki.watanabe@databricks.com>
Contributor
🛠 DevTools 🛠
Install mlflow from this PRFor Databricks, use the following command: |
harupy
reviewed
Mar 3, 2026
Member
There was a problem hiding this comment.
@B-Step62 Can't we split this PR, one to just remove the redundant "Hide assessments" toggle, one for the rest?
33 tasks
This was referenced Mar 4, 2026
Contributor
|
UI Preview for this PR has been removed. |
TomeHirata
approved these changes
Mar 5, 2026
Collaborator
TomeHirata
left a comment
There was a problem hiding this comment.
Change LGTM, but can we disable "Add Feedback/Expectation" button when the form is already displayed?
Collaborator
Author
|
@TomeHirata Makes sense! FYI I split this PR to two so will address it in #21379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Resolve ML-62939
Resolve ML-62964
What changes are proposed in this pull request?
Two minor assessment pane UX improvements:
Remove redundant "Hide assessments" toggle (ML-62939): The toggle button now returns
nullwhen the pane is expanded, since the close (x) button inside the pane already handles hiding. The "Show assessments" button still appears when the pane is collapsed.Remove assessment type dropdown and align terminology (ML-62964): The "Assessment Type" dropdown in the creation form is removed — the type is now determined by which section (Feedback or Expectations) the form is opened from. Updated terminology:
Before:
After:
How is this PR tested?
Updated 6 existing tests in
AssessmentCreateForm.test.tsxto reflect the removed dropdown and updated placeholders. All tests pass. Verified manually in the dev server.Does this PR require documentation update?
Does this PR require updating the MLflow Skills repository?
Release Notes
Is this a user-facing change?
Cleaned up the assessment pane UI: removed redundant "Hide assessments" toggle (close button suffices), removed the assessment type dropdown from the creation form (type is now inferred from context), and aligned terminology with the Feedback/Expectations split.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverHow should the PR be classified in the release notes? Choose one:
rn/bug-fix- A user-facing bug fix worth mentioning in the release notesShould this PR be included in the next patch release?