Skip to content

Add tooltip link to navigate to traces tab with time range filter#20466

Merged
serena-ruan merged 2 commits intomasterfrom
stack/trace_requests_tooltip_filter
Feb 3, 2026
Merged

Add tooltip link to navigate to traces tab with time range filter#20466
serena-ruan merged 2 commits intomasterfrom
stack/trace_requests_tooltip_filter

Conversation

@serena-ruan
Copy link
Collaborator

@serena-ruan serena-ruan commented Jan 30, 2026

🥞 Stacked PR

Use this link to review incremental changes.


Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Add 'view traces' link in tooltip so that we can jump to the traces view filtered by the current timestamp. This currently only works for a single bar, if users want an easy way to filter a certain range I think we should support changing time range based on zoom in & out behavior instead later.

The selected time range is preserved between overview tab and traces tab, so when we jump back to overview tab the charts are automatically updated

Screen.Recording.2026-01-30.at.6.27.45.PM.mov

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20466/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20466/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20466/merge

@github-actions github-actions bot added the rn/feature Mention under Features in Changelogs. label Feb 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “View traces for this period” link inside overview chart tooltips to navigate to the Traces tab with a time-range filter derived from the hovered bucket.

Changes:

  • Add timestampMs to trace requests/latency chart datapoints so tooltips can navigate based on the hovered bucket.
  • Extend ScrollableTooltip to optionally render a “View traces for this period” link and navigate to the Traces tab with startTimeLabel=CUSTOM, startTime, and endTime.
  • Add unit tests for the URL builder and basic tooltip/link rendering behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
mlflow/server/js/src/lang/default/en.json Adds localized message entry for the “View traces for this period” link text.
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/hooks/useTraceRequestsChartData.ts Includes timestampMs in requests chart datapoints for navigation.
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/hooks/useTraceLatencyChartData.ts Includes timestampMs in latency chart datapoints for navigation.
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/components/TraceRequestsChart.tsx Passes linkConfig into ScrollableTooltip and memoizes tooltip content.
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/components/TraceLatencyChart.tsx Passes linkConfig into ScrollableTooltip for latency chart tooltips.
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/components/OverviewChartComponents.tsx Implements traces URL builder and adds optional traces navigation link in tooltip.
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/components/OverviewChartComponents.test.tsx Adds tests for traces URL builder and tooltip link visibility.

@@ -1,12 +1,138 @@
import { describe, it, expect } from '@jest/globals';
import { render, screen, fireEvent } from '@testing-library/react';
import { renderHook } from '@testing-library/react';
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fireEvent is imported but not used. Either remove the import to keep the test file tidy, or use it in a click-navigation test for the new "View traces for this period" link.

Suggested change
import { renderHook } from '@testing-library/react';

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Documentation preview for 3e2871a is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

linkConfig={{
experimentId,
timeIntervalSeconds,
componentId: 'mlflow.overview.usage.latency.view_traces_link',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in managed codebase, there's a lint rule enforcing use of static componentIds so it will have to be addressed anyway. I think we can use static componentId="mlflow.overview.usage.latency.view_traces_link" prop on Typography.Link instead

Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@serena-ruan serena-ruan force-pushed the stack/trace_requests_tooltip_filter branch from 56945db to 3e2871a Compare February 3, 2026 04:35
@serena-ruan serena-ruan added this pull request to the merge queue Feb 3, 2026
Merged via the queue into master with commit e798d29 Feb 3, 2026
51 checks passed
@serena-ruan serena-ruan deleted the stack/trace_requests_tooltip_filter branch February 3, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/feature Mention under Features in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants