Skip to content

Add tooltip linking to traces for moving average charts of scorers#20503

Merged
serena-ruan merged 1 commit intomasterfrom
stack/assessments_tooltip
Feb 4, 2026
Merged

Add tooltip linking to traces for moving average charts of scorers#20503
serena-ruan merged 1 commit intomasterfrom
stack/assessments_tooltip

Conversation

@serena-ruan
Copy link
Collaborator

@serena-ruan serena-ruan commented Feb 2, 2026

🥞 Stacked PR

Use this link to review incremental changes.


Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Add tooltip link to traces for moving average chart, this applies the selected data point's time range filter, and assessment existence.

Screen.Recording.2026-02-02.at.5.45.07.PM.mov

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@serena-ruan serena-ruan force-pushed the stack/assessments_tooltip branch from 670dc3f to 5bf75da Compare February 2, 2026 09:39
@serena-ruan serena-ruan changed the title tooltip for moving average chart of assessments Add tooltip linking to traces for moving average charts of scorers Feb 2, 2026
@serena-ruan serena-ruan force-pushed the stack/assessments_tooltip branch from 5bf75da to 1888a19 Compare February 2, 2026 10:24
@serena-ruan serena-ruan marked this pull request as ready for review February 2, 2026 10:27
Copilot AI review requested due to automatic review settings February 2, 2026 10:27
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

🛠 DevTools 🛠

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20503/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/20503/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/20503/merge

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Feb 2, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for IS NULL/IS NOT NULL operators for assessment filters and implements tooltip links in overview charts that allow users to navigate to the traces tab with time range and assessment filters applied.

Changes:

  • Backend: Added IS NULL/IS NOT NULL operators support for assessment filters in the SQL store and search utilities
  • Frontend: Added IS_NULL and IS_NOT_NULL operators to the FilterOperator enum and updated filter UI to hide value input for null operators
  • Charts: Enhanced all overview charts with interactive tooltips that link to filtered traces views with appropriate time ranges and assessment filters

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/store/tracking/test_sqlalchemy_store.py Adds comprehensive tests for IS NULL/IS NOT NULL assessment filter functionality
mlflow/utils/search_utils.py Adds VALID_ASSESSMENT_COMPARATORS constant with null operators support
mlflow/store/tracking/sqlalchemy_store.py Implements SQL subquery logic for IS NULL/IS NOT NULL assessment filters
mlflow/server/js/src/shared/web-shared/genai-traces-table/types.ts Adds IS_NULL and IS_NOT_NULL to FilterOperator enum and helper function
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useMlflowTraces.tsx Updates filter routing to handle null operators correctly for assessments
mlflow/server/js/src/shared/web-shared/genai-traces-table/hooks/useFilters.tsx Allows filters without values when using null operators
mlflow/server/js/src/shared/web-shared/genai-traces-table/components/filters/TableFilterItem.tsx Adds null operators to assessment filter UI and conditionally hides value input
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/hooks/*.ts Adds timestampMs field to all chart data types for navigation support
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/components/*.tsx Updates all chart components to include tooltip links with proper memoization
mlflow/server/js/src/experiment-tracking/pages/experiment-overview/components/OverviewChartComponents.tsx Implements URL generation helpers, filter creators, and enhanced ScrollableTooltip with navigation support
mlflow/server/js/src/lang/default/en.json Adds internationalized messages for tooltip links
Test files Comprehensive test coverage for new functionality across backend and frontend

* @returns Filter string in format "column::operator::value::key"
*/
export function createAssessmentExistsFilter(assessmentName: string): string {
return [TracesTableColumnGroup.ASSESSMENT, HiddenFilterOperator.IS_NOT_NULL, '', assessmentName].join('::');
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function uses HiddenFilterOperator.IS_NOT_NULL but this creates an inconsistency because IS_NOT_NULL is now also available in the public FilterOperator enum (added in line 193 of types.ts). For consistency with how assessment filters are handled elsewhere in the codebase (e.g., in useMlflowTraces.tsx line 726 and TableFilterItem.tsx line 94), this should use FilterOperator.IS_NOT_NULL instead of HiddenFilterOperator.IS_NOT_NULL.

The HiddenFilterOperator enum was originally intended for operators not displayed in the UI, but now that IS_NULL and IS_NOT_NULL are user-facing operators for assessments, they should use the public FilterOperator enum.

Suggested change
return [TracesTableColumnGroup.ASSESSMENT, HiddenFilterOperator.IS_NOT_NULL, '', assessmentName].join('::');
return [TracesTableColumnGroup.ASSESSMENT, FilterOperator.IS_NOT_NULL, '', assessmentName].join('::');

Copilot uses AI. Check for mistakes.
Comment on lines +28 to +29
// IS NULL / IS NOT NULL operators don't require a value
if (!column || !urlOperator || (!value && !isNullOperator(urlOperator))) return filters;
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check on line 29 correctly allows null operators to proceed without a value. However, for assessment filters with null operators, the empty value string will be passed to serializedStringToAssessmentValueV2 at line 36 (outside the diff), which returns an empty string. While this doesn't cause bugs since the value isn't used for null operators, it would be clearer to explicitly handle null operators by setting the value to undefined when a null operator is used, making it clear that no value is needed for these operators.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Documentation preview for 3765fca is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@serena-ruan serena-ruan force-pushed the stack/assessments_tooltip branch 3 times, most recently from 181f149 to 066f643 Compare February 3, 2026 08:21
@serena-ruan serena-ruan force-pushed the stack/assessments_tooltip branch 2 times, most recently from 4ced762 to 9a320be Compare February 3, 2026 10:28
Signed-off-by: Serena Ruan <serena.rxy@gmail.com>
@serena-ruan serena-ruan added this pull request to the merge queue Feb 4, 2026
Merged via the queue into master with commit ad93fb5 Feb 4, 2026
52 of 55 checks passed
@serena-ruan serena-ruan deleted the stack/assessments_tooltip branch February 4, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rn/none List under Small Changes in Changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants