Skip to content

Pass tracking URI#18023

Merged
B-Step62 merged 7 commits intomlflow:masterfrom
shaperilio:fix/tracking_leak
Dec 3, 2025
Merged

Pass tracking URI#18023
B-Step62 merged 7 commits intomlflow:masterfrom
shaperilio:fix/tracking_leak

Conversation

@shaperilio
Copy link
Contributor

@shaperilio shaperilio commented Sep 30, 2025 •
edited
Loading

Related Issues/PRs

Resolve #14931

What changes are proposed in this pull request?

Pass the tracking URI when obtaining the artifact repository, as done by #16461.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025

@shaperilio Thank you for the contribution! Could you fix the following issue(s)?

⚠ DCO check

The DCO check failed. Please sign off your commit(s) by following the instructions here. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.md#sign-your-work for more details.

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. v3.4.1 labels Sep 30, 2025
@shaperilio
Pass tracking URI
0c66102 
Signed-off-by: Emilio Graff <1@emil.io>
@shaperilio
Copy link
Contributor Author

shaperilio commented Oct 17, 2025

Do I need to do something here?

@shaperilio shaperilio mentioned this pull request Oct 21, 2025
Merged
29 tasks
@shaperilio
Copy link
Contributor Author

shaperilio commented Oct 31, 2025

@BenWilson2 do you mind taking a quick look at this?

@shaperilio
Copy link
Contributor Author

shaperilio commented Nov 10, 2025

@B-Step62 do you mind taking a quick look at this? Together with #18417, I believe it fully isolates non-fluent users from having to set the tracking URI globally through the fluent interface.

BenWilson2
BenWilson2 approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@BenWilson2 BenWilson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one got missed in that last bug fix - thanks for the follow up here!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

Documentation preview for 3787998 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@shaperilio
Copy link
Contributor Author

shaperilio commented Nov 11, 2025

Looks like one got missed in that last bug fix - thanks for the follow up here!

Sorry, I don't understand your comment.

Also not sure what's going on with all these failures here. Let me know if you want me to update the branch, etc. This is a very simple change...

@BenWilson2
Copy link
Member

BenWilson2 commented Nov 14, 2025

@shaperilio Can you run the pre-commit hooks on your branch to fix the lint failures?

@shaperilio
Revert "Pass tracking URI"
2adffbb 
This reverts commit 0c66102.

Signed-off-by: Emilio Graff <1@emil.io>
@shaperilio
Redo of 0c66102 for pre-commit
9ece77b 
Signed-off-by: Emilio Graff <1@emil.io>
@shaperilio
Copy link
Contributor Author

shaperilio commented Nov 14, 2025

@BenWilson2 I reproduced the arg change after ensuring pre-commit hooks were installed.

Previously, your workflow was telling me to format the entire file. Is that really what you want?

@shaperilio
Fix arg in test
85df87d 
Signed-off-by: Emilio Graff <1@emil.io>
@shaperilio
Copy link
Contributor Author

shaperilio commented Nov 18, 2025

@BenWilson2 I fixed the failing test to the best of my ability. I'm not sure what the timeouts are about on the MCP test; maybe it will magically go away with this last commit.

@shaperilio
Copy link
Contributor Author

shaperilio commented Dec 3, 2025

Can I get eyes on this? I think it's good to go.

@B-Step62 B-Step62 enabled auto-merge December 3, 2025 04:15
@B-Step62 B-Step62 added the v3.7.0 label Dec 3, 2025
@B-Step62 B-Step62 added this pull request to the merge queue Dec 3, 2025
Merged via the queue into mlflow:master with commit b3f61b2 Dec 3, 2025
46 checks passed
@B-Step62
Copy link
Collaborator

B-Step62 commented Dec 3, 2025

@shaperilio Sorry for the delay, just merged the PR and this will be available in 3.7.0 in a few days.

BenWilson2 added a commit to BenWilson2/mlflow that referenced this pull request Dec 4, 2025
@shaperilio @BenWilson2 @B-Step62
Pass tracking URI (mlflow#18023)
1756e9e 
Signed-off-by: Emilio Graff <1@emil.io>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Co-authored-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
BenWilson2 added a commit that referenced this pull request Dec 4, 2025
@shaperilio @BenWilson2 @B-Step62
Pass tracking URI (#18023)
5bd6ee7 
Signed-off-by: Emilio Graff <1@emil.io>
Co-authored-by: Ben Wilson <39283302+BenWilson2@users.noreply.github.com>
Co-authored-by: Yuki Watanabe <31463517+B-Step62@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWilson2 BenWilson2 BenWilson2 approved these changes

Assignees

No one assigned

Labels

area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. v3.4.1 v3.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] fluent/global dependencies in MlflowClient api (artifact repo)

3 participants

@shaperilio @BenWilson2 @B-Step62