Skip to content

Allow passing in tracking URI#18417

Merged
B-Step62 merged 4 commits intomlflow:masterfrom
shaperilio:fix/system_metrics_monitor_uri
Nov 10, 2025
Merged

Allow passing in tracking URI#18417
B-Step62 merged 4 commits intomlflow:masterfrom
shaperilio:fix/system_metrics_monitor_uri

Conversation

@shaperilio
Copy link
Contributor

@shaperilio shaperilio commented Oct 20, 2025

🛠 DevTools 🛠

Open in GitHub Codespaces

Install mlflow from this PR

# mlflow
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18417/merge
# mlflow-skinny
pip install git+https://github.com/mlflow/mlflow.git@refs/pull/18417/merge#subdirectory=libs/skinny

For Databricks, use the following command:

%sh curl -LsSf https://raw.githubusercontent.com/mlflow/mlflow/HEAD/dev/install-skinny.sh | sh -s pull/18417/merge

Related Issues/PRs

Resolve #18413

What changes are proposed in this pull request?

Allows passing in a tracking URI to SystemMetricsMonitor so it need not be set via fluent interface.

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

(Happy to write more tests, but I cannot get a dev environment installed. See #18385.

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Allows passing in the tracking URI when constructing SystemMetricsMonitor instances.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/tracking: Tracking Service, tracking client APIs, autologging
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/evaluation: MLflow model evaluation features, evaluation metrics, and evaluation workflows
  • area/gateway: MLflow AI Gateway client APIs, server, and third-party integrations
  • area/prompts: MLflow prompt engineering features, prompt templates, and prompt management
  • area/tracing: MLflow Tracing features, tracing APIs, and LLM tracing functionality
  • area/projects: MLproject format, project running backends
  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: Emilio Graff <1@emil.io>
@github-actions github-actions bot added v3.5.1 area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs. labels Oct 20, 2025
Signed-off-by: Emilio Graff <1@emil.io>
@shaperilio
Copy link
Contributor Author

This would go well with #18023 to further button up this separation.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Documentation preview for bb6de62 is available at:

More info
  • Ignore this comment if this PR does not change the documentation.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by this workflow run.
  • The documentation was built by this workflow run.

@BenWilson2 BenWilson2 added v3.5.2 and removed v3.5.1 labels Oct 21, 2025
@BenWilson2
Copy link
Member

@shaperilio there are a few unit tests related to system metrics monitoring that need to be looked into (call counts)

Signed-off-by: Emilio Graff <1@emil.io>
@shaperilio
Copy link
Contributor Author

Thanks @BenWilson2, I've fixed these now.

Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@B-Step62 B-Step62 added this pull request to the merge queue Nov 10, 2025
Merged via the queue into mlflow:master with commit 3f37c03 Nov 10, 2025
46 of 48 checks passed
@shaperilio shaperilio mentioned this pull request Nov 10, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tracking Tracking service, tracking client APIs, autologging rn/none List under Small Changes in Changelogs. v3.5.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SystemMetricsMonitor should store a reference to the tracking_uri

3 participants