scan assignment value in drop_unused()#1578
Merged
alexlamsl merged 1 commit intomishoo:masterfrom Mar 8, 2017
Merged
Conversation
those were not optimised for `unused` before, which made it necessary for `reduce_vars` to have separate steps for `keep_fnames` docs update by @kzc closes mishoo#1577
Contributor
|
Thanks. LGTM. |
Closed
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Mar 8, 2017
similar case as mishoo#1578 but against mishoo#1450 instead closes mishoo#1580
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
Mar 8, 2017
- similar case as mishoo#1578 but against mishoo#1450 instead - fix `this` binding in mishoo#1450 as well closes mishoo#1580
alexlamsl
added a commit
that referenced
this pull request
Mar 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1576 (comment)
So this covers more than just missed opportunity for
!keep_fnamesin named functions as assigned values, and it's also less lines than before.@kzc included your doc changes from #1577, and thanks for pointing out the inefficiency in the previous PR 😉